Repository navigation
Diff PRs without rename detection when picking test versions - #54
Merged
Merged
Conversation
With Git's default rename detection, git diff --name-only lists only the destination of a moved file. Moving a file from common/ into 7.4/ would then test only 7.4, and moving one from 7.4/ to 8.3/ would test only 8.3. --no-renames lists both paths, so the source side is considered too. Refs #51 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uugex1w8qZoTbBRbcFwkcp
There was a problem hiding this comment.
🟢 Approval recommended
The focused flag change correctly includes both sides of moved files, with no unresolved review findings.
No open issues 🎉
What changed in this PR
This follow-up to #53 fixes test-version selection for moved files, supporting #51’s goal of testing only affected PHP versions.
Changes:
- Adds
--no-renamesto the PR diff so both source and destination paths inform test selection. - Preserves existing matrix filtering, fallback behavior, and push behavior.
| File | Description |
|---|---|
.github/workflows/build.yml |
Disables rename detection when collecting changed paths for test-version selection. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #51. Follow-up to #53, from Copilot's review of it.
git diff --name-onlyuses rename detection by default and lists only the destination of a moved file, so the version selection added in #53 could miss the source side of a move.Notable Changes
git diff --name-only --no-renamesin thematrixjob, so a move is listed as a deletion plus an addition.QA
common/php.batsto7.4/php.batslists only7.4/php.batsby default, and both paths with--no-renames.common/into7.4/tests all 7 versions, a move from7.4/to8.3/tests 7.4 and 8.3, and7.4/-only changes still test just 7.4.Deployment
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Uugex1w8qZoTbBRbcFwkcp