Repository navigation
feat: add opt-in GridStack layouts with nested containers - #329
Open
daniil-filippov-dev wants to merge 16 commits into
Conversation
Contributor
|
Preview is ready. |
daniil-filippov-dev
marked this pull request as ready for review
October 23, 2026 09:42
daniil-filippov-dev
requested review from
Marginy605,
mournfulCoroner and
roberthovsepyan
as code owners
October 23, 2026 09:42
daniil-filippov-dev
marked this pull request as draft
October 23, 2026 09:56
daniil-filippov-dev
marked this pull request as ready for review
October 23, 2026 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI TLDR
Add an opt-in GridStack renderer with nested containers and run the same supported flat DashKit contract against legacy and GridStack.
🤖 AI-generated
Depends on #328. Merge preparation first, then update this branch from
mainif needed and retarget this PR tomainbefore merging.The root entry keeps the legacy renderer. The new
@gravity-ui/dashkit/gridstackentry provides native layout, nested document validation/serialization, controlled restoration and layout projection, sharing plugin registration, lifecycle and ref methods with legacy.Normal
npm testruns the ten common flat scenarios introduced by #328 against both actual renderers with identical assertions: nine mounted widget scenarios and one flat statics scenario per engine. Pure helpers run once; engine-specific suites remain separate. Storybook-backed TypeScript Playwright specs replace the standalone CJS harness. Chromium native contracts run in CI; Firefox and WebKit projects are also available.Nested visual autoheight respects finite containers without changing saved height. Explicit item-update isolation preserves legacy defaults. Authoritative controlled revisions cancel stale gestures; widgets in unrendered groups keep canonical membership and refs during later saves. Nested nowrap constraints stay in local grid units and include container footprints. Nested grids measure their own content width and retain a full-height empty drop surface under fixed root styling, keeping mounted geometry consistent with snapshot projection. Valid positive fractional saved sizes survive reflow, unrelated additions and ordinary nowrap moves; explicit resize minimums remain enforced. Custom drag handles bind after portal content appears and support updates, HTML/SVG button content and view/edit changes while preserving custom resize controls and widget identity.
Validation of final
6c00f26on Node 22 and React 19: 240 Jest tests in 18 suites; all ten common callback bodies match preparation. Native browser checks passed 25 cases across Chromium/Firefox/WebKit, with two existing Chromium-CDP touch skips on Firefox/WebKit. Types, lint, styles/format, library and Storybook builds passed. The packed ESM/CJS/type artifact matches all 166 committed JS sourcemap sources and ships no tests or local evidence. DataLens passed 83 focused regressions plus both UI type programs against this exact local package on Node 24; temporary dependency changes were restored.Fresh independent Codex sessions applied codebase-design, ponytail-review and review-pull-request. All confirmed findings were fixed and independently rechecked on final
6c00f26; no actionable findings remain. The last review includes independent parallel Standards and Spec passes on its review baseline, followed by revalidation of all affected candidates and final changes. All applicable final-head GitHub CI checks are green.Existing lint/Storybook warnings remain; full lint reports 76 pre-existing warnings and no new sites. React 18 CI is release-only; other React peer versions were not separately revalidated here. Actual DataLens latency and PDF/export acceptance remain pending, and consumers require a released dependency version.