Repository navigation
snapshot gate - #721
Merged
Merged
snapshot gate#721
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, targeted, and align local test execution with existing snapshot gating, with only a minor comment-doc fix suggested.
Pull request overview
This PR adjusts the local test runner and one legend snapshot test to avoid a failure caused by snapshot plotting being gated off (i.e., the warning only occurs when the plot is actually drawn).
Changes:
- Set
NOT_CRAN=trueinmake testallandmake testoneso local runs follow the “run snapshots when permitted” path. - Add a
snapshots_runhelper flag mirroring tinysnapshot’s snapshot-plot gating logic. - Guard a warning assertion in
test-legend.Rso it only runs when snapshots are actually executed.
File summaries
| File | Description |
|---|---|
| Makefile | Exports NOT_CRAN=true for testall/testone to prevent snapshot-gate-related failures in local runs. |
| inst/tinytest/test-legend.R | Skips expect_warning(expect_snapshot_plot(...)) when snapshots aren’t drawn, avoiding a false failure. |
| inst/tinytest/helpers.R | Introduces snapshots_run gate for tests that need to know whether snapshot plotting will occur. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
Author
|
Confirmed that it runs fine on Mac too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix annoying
make testallchoke.(Still need to test on a Mac.)