Skip to content

chore: gax linter fixes - #9235

Merged
bshaffer merged 1 commit into
shivaneep-o11y-generator-templatesfrom
shivaneep-gax-linter-fix
Sep 3, 2026
Merged

chore: gax linter fixes#9235
bshaffer merged 1 commit into
shivaneep-o11y-generator-templatesfrom
shivaneep-gax-linter-fix

Conversation

@shivanee-p

Copy link
Copy Markdown
Contributor

Resolves legacy ESLint promise violations in core/packages/gax/test/unit/grpc.ts and grpc-fallback.ts

  • Wrapped callback-based RPC calls in Promise constructs
  • added async() + await callbacks

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces telemetry tracing configuration generation in the GAPIC generator for TypeScript (supporting both CJS and ESM templates) and updates the google-gax library to accept and propagate enableTelemetryTracing and internalTelemetryInfo parameters. Additionally, it modernizes several unit tests to use async/await instead of callbacks or promise chains. The review feedback highlights opportunities to avoid variable shadowing in the fallback tests by renaming caught error variables, and to simplify assert.rejects calls in the gRPC tests by passing promises directly instead of wrapping them in unnecessary async arrow functions.

Comment thread core/packages/gax/test/unit/grpc-fallback.ts Outdated
Comment thread core/packages/gax/test/unit/grpc-fallback.ts Outdated
Comment thread core/packages/gax/test/unit/grpc-fallback.ts Outdated
Comment thread core/packages/gax/test/unit/grpc-fallback.ts Outdated
Comment thread core/packages/gax/test/unit/grpc-fallback.ts Outdated
Comment thread core/packages/gax/test/unit/grpc.ts Outdated
Comment thread core/packages/gax/test/unit/grpc.ts Outdated
Comment thread core/packages/gax/test/unit/grpc.ts Outdated
@shivanee-p
shivanee-p force-pushed the shivaneep-gax-linter-fix branch from becf578 to 8b07008 Compare September 2, 2026 05:55
@shivanee-p
shivanee-p changed the base branch from main to shivaneep-o11y-generator-templates September 2, 2026 05:55
@shivanee-p
shivanee-p force-pushed the shivaneep-gax-linter-fix branch from 8b07008 to 0a411f9 Compare September 2, 2026 05:59
@shivanee-p
shivanee-p requested review from feywind and removed request for a team and westarle September 2, 2026 18:45

@danieljbruce danieljbruce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The async tests are cleaner to read too!

@bshaffer
bshaffer force-pushed the shivaneep-gax-linter-fix branch from 0a411f9 to dced270 Compare September 3, 2026 17:24
@bshaffer
bshaffer merged commit ab2dc24 into main Sep 3, 2026
64 of 67 checks passed
@bshaffer
bshaffer deleted the shivaneep-gax-linter-fix branch September 3, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants