chore: gax linter fixes - #9235
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces telemetry tracing configuration generation in the GAPIC generator for TypeScript (supporting both CJS and ESM templates) and updates the google-gax library to accept and propagate enableTelemetryTracing and internalTelemetryInfo parameters. Additionally, it modernizes several unit tests to use async/await instead of callbacks or promise chains. The review feedback highlights opportunities to avoid variable shadowing in the fallback tests by renaming caught error variables, and to simplify assert.rejects calls in the gRPC tests by passing promises directly instead of wrapping them in unnecessary async arrow functions.
becf578 to
8b07008
Compare
8b07008 to
0a411f9
Compare
danieljbruce
left a comment
There was a problem hiding this comment.
LGTM. The async tests are cleaner to read too!
0a411f9 to
dced270
Compare
Resolves legacy ESLint promise violations in core/packages/gax/test/unit/grpc.ts and grpc-fallback.ts