feat(firestore): support conversion and serialization for Temporal.Instant - #9216
feat(firestore): support conversion and serialization for Temporal.Instant#9216MarkDuckworth wants to merge 7 commits into
Conversation
product-auto-label
Bot
added
the
api: firestore
| // Warning: (tsdoc-escape-right-brace) The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag | ||
| // Warning: (tsdoc-malformed-inline-tag) Expecting a TSDoc tag starting with "{@" | ||
| // Warning: (tsdoc-undefined-tag) The TSDoc tag "@return" is not defined in this configuration | ||
| static minimum(n: number): FieldValue; |
There was a problem hiding this comment.
API report must have been missed for minimum and maximum. Cloud Node CI does no enforce that api report is run on all PRs.
There are no changes related to minimum and maximum in this PR.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the ECMAScript Temporal API (Temporal.Instant) to Firestore, introducing fromInstant and toInstant methods on the Timestamp class, updating serialization logic, and adding corresponding tests. The review feedback suggests moving the @js-temporal/polyfill package to devDependencies since it is only used in tests, and removing JSDoc-style curly braces from the TSDoc comments in timestamp.ts to resolve API report warnings.
…simplify isTemporalInstant
| import { protos } from '@google-cloud/firestore-api'; | ||
| import * as protos_2 from '../../protos/firestore_v1_proto_api'; |
There was a problem hiding this comment.
Do you know why this changed? Is this because we're moving the protos/apis out to a separate package?
There was a problem hiding this comment.
this is unexpected. good catch. I'm uncertain why this would have been introduced today but not last week
2 participants
Fixes #8087