Skip to content

fix(compute): remove sponge dependency from update_discovery_doc script - #16425

Open
colinmoy wants to merge 2 commits into
googleapis:mainfrom
colinmoy:fix-compute-discovery-sponge-dependency
Open

fix(compute): remove sponge dependency from update_discovery_doc script#16425
colinmoy wants to merge 2 commits into
googleapis:mainfrom
colinmoy:fix-compute-discovery-sponge-dependency

Conversation

@colinmoy

@colinmoy colinmoy commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@colinmoy
colinmoy requested a review from a team as a code owner September 8, 2026 19:54
@product-auto-label product-auto-label Bot added the api: compute Issues related to the Compute Engine API. label Sep 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates generator/discovery/update_discovery_doc.sh to use local variables and replaces the sponge command with a temporary file using mktemp and mv. The review feedback suggests creating the temporary file in the same directory as the target file to ensure that the mv operation is atomic and avoids cross-filesystem copy overhead.

Comment thread generator/discovery/update_discovery_doc.sh Outdated
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (73bb942) to head (709f5f4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16425   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files        2246     2246           
  Lines      212584   212584           
=======================================
+ Hits       196169   196171    +2     
+ Misses      16415    16413    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant