fix(compute): remove sponge dependency from update_discovery_doc script - #16425
Open
colinmoy wants to merge 2 commits into
Open
fix(compute): remove sponge dependency from update_discovery_doc script#16425colinmoy wants to merge 2 commits into
colinmoy wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates generator/discovery/update_discovery_doc.sh to use local variables and replaces the sponge command with a temporary file using mktemp and mv. The review feedback suggests creating the temporary file in the same directory as the target file to ensure that the mv operation is atomic and avoids cross-filesystem copy overhead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16425 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 2246 2246
Lines 212584 212584
=======================================
+ Hits 196169 196171 +2
+ Misses 16415 16413 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.