Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3915 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 16 16
Lines 2466 2466
=======================================
Hits 2292 2292
Misses 174 174 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66241a4fed
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // While there are not currently any warnings that this suppresses | ||
| // (that we're aware of), it's good future-proofing hygiene. | ||
| #[automatically_derived] | ||
| const _: () = { |
There was a problem hiding this comment.
Regenerate snapshots after changing const_block output
When the zerocopy-derive output tests run, every expansion produced here now omits #[automatically_derived], but the checked-in fixtures (for example, src/output_tests/expected/from_bytes_struct.expected.rs) still expect that attribute immediately before const _: (). The test helper in src/output_tests/mod.rs pretty-prints and compares these token streams exactly, so the affected tests will panic and block CI until the expected outputs are regenerated.
Useful? React with 👍 / 👎.
This showed up while trying to build rustc in rust-lang/rust#165441 (comment)
I think this won't pass CI but I cannot run tests locally, they fail with