Export domain drop list for open TLDs to Drive - #3223
Conversation
b41b53d to
9b80bd8
Compare
b5efc1a to
2f22abf
Compare
2f22abf to
a773150
Compare
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 12 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on CydeWeys).
core/src/main/java/google/registry/export/ExportDropListAction.java line 62 at r4 (raw file):
ImmutableList.of("domain_name", "tld", "deletion_time"); private static final CSVFormat CSV_FORMAT = CSVFormat.DEFAULT.builder().setRecordSeparator('\n').build();
use "get" instead of "build"
core/src/test/java/google/registry/export/ExportDropListActionTest.java line 112 at r4 (raw file):
// Pending delete domains on open TLDs -> included persistResource(
(i'm pretty sure it's possible) better to just call persistDeletedDomain for these ones
a773150 to
e644ac6
Compare
Redo the exported drop list mechanism by replacing the legacy per-TLD mode in ExportDomainListsAction with a dedicated, once-daily ExportDropListAction. Key changes: 1. Reverted ExportDomainListsAction to unconditionally export single-column active registered domains and deprecated the INCLUDE_PENDING_DELETE_DATE_FOR_DOMAINS feature flag. 2. Implemented ExportDropListAction at /_dr/task/exportDropList to query the read replica for upcoming deletions on all open TLDs (where invoicing is enabled) and output an alphabetically sorted CSV file (domain_name,tld,deletion_time) to a designated Google Drive folder. 3. Added domainDropListDriveFolderId configuration setting and provider. 4. Registered the action in RequestComponent, routing.txt, and Cloud Scheduler tasks for production and sandbox. 5. Added comprehensive test coverage in ExportDropListActionTest and cleaned up legacy test cases in ExportDomainListsActionTest. BUG=b/553658111
e644ac6 to
3351744
Compare
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys made 2 comments and resolved 2 discussions.
Reviewable status: 10 of 12 files reviewed, 2 unresolved discussions (waiting on gbrodman).
core/src/main/java/google/registry/export/ExportDropListAction.java line 62 at r4 (raw file):
Previously, gbrodman wrote…
use "get" instead of "build"
Done.
core/src/test/java/google/registry/export/ExportDropListActionTest.java line 112 at r4 (raw file):
Previously, gbrodman wrote…
(i'm pretty sure it's possible) better to just call persistDeletedDomain for these ones
Done.
CydeWeys
left a comment
There was a problem hiding this comment.
PTAL
@CydeWeys made 1 comment.
Reviewable status: 10 of 12 files reviewed, 2 unresolved discussions (waiting on gbrodman).
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
Redo the exported drop list mechanism by replacing the legacy per-TLD mode in ExportDomainListsAction with a dedicated, once-daily ExportDropListAction.
Key changes:
BUG=b/553658111
This change is