Add XAP registrar flag and drop DB defaults - #3222
Merged
Merged
Conversation
Expose the --expiry_access_period_enabled CLI flag on registrar mutation commands and drop temporary database-level default constraints for XAP. Specifically: - Expose the --expiry_access_period_enabled parameter in CreateOrUpdateRegistrarCommand and pass it to Registrar.Builder.setExpiryAccessPeriodEnabled. - Add expiryAccessPeriodTransitions with default DISABLED to example.yaml. - Add unit tests for --expiry_access_period_enabled in CreateRegistrarCommandTest and UpdateRegistrarCommandTest. - Add Flyway migrations V229 and V230 to drop the temporary database-level DEFAULT constraints on Tld.expiry_access_period_transitions and Registrar.expiry_access_period_enabled per db/README.md. - Regenerate flyway.txt, nomulus.golden.sql, and ER diagrams. TAG=agy BUG=http://b/437398822
gbrodman
approved these changes
Aug 31, 2026
gbrodman
left a comment
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
@gbrodman reviewed 10 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the --expiry_access_period_enabled CLI flag on registrar mutation commands and drop temporary database-level default constraints for XAP.
Specifically:
TAG=agy
BUG=http://b/437398822
This change is