fix: return None for unsupported epoch timestamps - #1043
Closed
Shubham-Padkonde wants to merge 1 commit into
Closed
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Collaborator
|
Closing this PR. We do not accept AI-generated PRs targeting synthetic edge cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
epoch_to_human_timepromisesNonefor invalid input, but timestamps outside the platform's supported range can raiseOverflowErrororOSErrorinstead. Very large integers can also overflow during conversion to seconds. This can escape into callers such as test-record representation.Handle those conversion failures alongside the existing
ValueErrorcase. Tests cover positive and negative out-of-range integers, overflow during division, platform conversion exceptions, valid formatting, and existing non-integer behavior.Validation: six regression subcases fail before the fix; 86 utility/record tests and seven subtests pass afterward, with four platform skips. Pyink and
git diff --checkpass.