Repository navigation
fix: deduplicate discovered subclasses - #1042
Closed
Shubham-Padkonde wants to merge 1 commit into
Closed
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Collaborator
|
Closing this PR. We do not accept AI-generated PRs targeting synthetic edge cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subclass discovery can return the same class multiple times when a module aliases it or when it matches more than one requested base class. As a result,
find_subclass_in_modulecan reject a module containing only one distinct test class.Return each matching class once, preserve discovery order, and stop checking bases after a match. Regressions cover aliases and overlapping/repeated bases; existing tests retain coverage for genuinely different subclasses.
Validation: both regressions fail before the fix; 55 utility tests pass and four platform-specific tests skip afterward. Pyink and
git diff --checkpass.