fix(python): check each parameter in native callback validation loop - #1335
Open
jdymitarai wants to merge 1 commit into
Open
fix(python): check each parameter in native callback validation loop#1335jdymitarai wants to merge 1 commit into
jdymitarai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
python/_jsonnet.c,handle_native_callbacksvalidates that each parameter specified in a native callback's parameter tuple is a string:The loop was indexing
paramsat index0instead of loop counteri. As a consequence:(('name', 123), cb)), the loop repeatedly validated parameter 0 and completely skipped subsequent parameters.get_py_utf8_stringcalledPyUnicode_AsUTF8Stringon the non-string object, which set an uncaught exception on the CPython thread state and produced a NULL string pointer.evaluate_snippetthen returned a result with an active exception, causing CPython to raise:SystemError: <built-in function evaluate_snippet> returned a result with an exception setChanges
PyTuple_GetItem(params, 0)toPyTuple_GetItem(params, i).test_native_callback_param_type_validationinpython/_jsonnet_test.py.