fix: retain Python native callback parameter names until registration - #1333
Open
rksharma-owg wants to merge 1 commit into
Open
fix: retain Python native callback parameter names until registration#1333rksharma-owg wants to merge 1 commit into
rksharma-owg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1321.
Keep each Python callback parameter's UTF-8 storage alive until
jsonnet_native_callbackhas copied the names. With the pre-3.10 limited API, releasing each temporary bytes object inside the conversion loop leaves dangling pointers: later names can overwrite earlier ones, producing duplicate-binding errors even for distinct parameters.The regression covers two and three multicharacter parameters and out-of-order named arguments. It fails in all three cases on the unchanged source with a CPython 3.9 build targeting the Python 3.8 stable ABI. After the fix, all 11 Python binding tests pass on both Python 3.9 and Python 3.13 using that same stable-ABI extension.
git diff --checkalso passes.