fix: reject non-integer dynamic format arguments - #1332
Open
rksharma-owg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1331
std.formataccepted non-integer values supplied through*field width and precision. Because those values flow into recursive padding and numeric formatting as if they were integers, malformed output could be produced instead of an error. Validate both dynamic arguments before formatting while preserving existing integer behavior.Validation
JSONNET_BIN=../jsonnet ./test_suite/run_tests.sh(175 tests)git diff --checkThe issue also reports separate large-number conversion discrepancies; this focused change addresses the reproducible dynamic width/precision contract violation.