Repository navigation
Conversation
Remove ko from the build and deploy flow. The new `make images` target cross-compiles ax-server and ax-task-runner for linux/$IMAGE_ARCH, builds their container images with podman (falling back to docker), and pushes them to $AX_IMAGE_REPO. AX_IMAGE_REPO is required, and IMAGE_TAG overrides the default `latest` tag. `make deploy-server` now fills in the ax-server image in deploy/ax-server.yaml. It also sets AX_DEFAULT_TASK_IMAGE, so the server runs the task-runner image you pushed for tasks that do not set spec.image. Since the default tag is `latest`, imagePullPolicy is now Always. Other changes: - Delete .ko.yaml. - Move Dockerfile.server from test/e2e/ to the repo root so the e2e setup and `make images` share it. - Remove redundant Makefile targets (all, build-binaries, build-task-runner, push-task-runner, push). - Update README, CONTRIBUTING, and docs to use `make images`.
mayawang
reviewed
Oct 22, 2026
mayawang
left a comment
mayawang
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @rakyll, dropping ko is a big step for onboarding. One issue: deploy-server sets AX_DEFAULT_TASK_IMAGE to the :latest tag, and Substrate rejects images that aren't pinned by digest, so any task without spec.image fails at template creation. Could images resolve the pushed digest and deploy-server use image@sha256:... instead? The old push-task-runner printed it. Also heads-up: this conflicts with #505 in README.md, and #500's install guide is built around ko, so it'll need updating after this lands. I'd suggest landing #505 first.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove ko from the build and deploy flow. The new
make imagestarget cross-compiles ax-server and ax-task-runner for linux/$IMAGE_ARCH, builds their container images with podman (falling back to docker), and pushes them to $AX_IMAGE_REPO. AX_IMAGE_REPO is required, and IMAGE_TAG overrides the defaultlatesttag.make deploy-servernow fills in the ax-server image in deploy/ax-server.yaml. It also sets AX_DEFAULT_TASK_IMAGE, so the server runs the task-runner image you pushed for tasks that do not set spec.image. Since the default tag islatest, imagePullPolicy is now Always.Other changes:
make imagesshare it.make images.