Repository navigation
server: log Substrate actors that have no Task record at startup - #507
Open
itssimrank wants to merge 1 commit into
Open
itssimrank wants to merge 1 commit into
itssimrank wants to merge 1 commit into
Conversation
A Redis restart drops every Task record while the Substrate actors keep running, so ax no longer knows about sandboxes that still hold worker slots (#442). Until state moves to Postgres and the server reconciles against Substrate, make the divergence visible: at startup, list all actors and all tasks and log a warning for each actor with no matching atespace/name. The check only logs, is bounded to 30s, and a failure does not stop the server. Tasks are read in one call rather than paged by offset, because a delete between pages would shift the list and could skip a live task. Carried in from rkb32/ax:orphan-check at the maintainer's request on the issue; implementation and tests are rkb32's. Part of #442
Member
|
See my comment at #510 (comment). |
Member
|
See #515. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Redis restart drops every Task record while the Substrate actors keep running, so ax no longer knows about sandboxes that still hold worker slots (#442). Make the divergence visible: at startup, list all actors and all tasks and log a warning for each actor with no matching atespace/name. The check only logs, is bounded to 30s, and a failure does not stop the server.
Tasks are read in one call rather than paged by offset, because a delete between pages would shift the list and could skip a live task.
Carried in from rkb32/ax:orphan-check at the maintainer's request on the issue; implementation and tests are rkb32's.
Part of #442