Repository navigation
fix(streaming): preserve array indexes in progressive tool arguments - #1155
Open
KevinAndrewDong wants to merge 1 commit into
Open
KevinAndrewDong wants to merge 1 commit into
KevinAndrewDong wants to merge 1 commit into
Conversation
KevinAndrewDong
marked this pull request as ready for review
October 25, 2026 05:28
Contributor
|
Hi @KevinAndrewDong, thank you for raising the PR to fix the issue. We have reviewed the code changes and it does resolve the issue. I will escalate the PR to the team to review, thank you for your patience and understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem: In opt-in Vertex progressive streaming, indexed argument paths are accumulated as numeric-key objects and can fail a real FunctionTool array parameter.
Solution: Distinguish unquoted array indexes from quoted numeric member names before JSONPath parsing, accumulate ordinary objects, and project only contiguous indexed containers when finalizing arguments.
Testing Plan
Unit Tests:
Frozen cloud evidence at
f882b34ad57d24e911324dcda124499cfb726381: baseline 136 passed / 10 failed / 0 skipped; fixed 146 passed / 0 failed / 0 skipped. The 18 new cases are included in 146; independent reruns repeat those cases and are not additional coverage. Counts from other fixes are not added.Fresh Mac validation (Node 22.23.2, one worker, same scoped files): unmodified production source 136 passed / 10 failed / 0 skipped; this fix 146 passed / 0 failed / 0 skipped. The expected failures occur only in the supplied new regression files; no test-name filter was used.
Scoped Mac command:
Mac core build, workspace declaration preparation, root/sample type checks, changed-file ESLint/Prettier, diff/title checks and normal Husky/lint-staged commit checks passed. An independent read-only review covered these exact frozen source/test bytes. Cloud and Mac executions are separate evidence, not additive coverage.
Manual End-to-End (E2E) Tests:
Not performed in this Mac preparation. Full workspace build/suite, coverage, live provider/API, browser/manual E2E and full platform matrices are not established.
Checklist
Additional context
Experimental Vertex progressive mode remains default-off; this is not default Gemini API, full RFC9535 or provider integration coverage. Conflicting path forms and complete RFC9535 semantics are outside this change.
Prepared with Codex.