Repository navigation
fix(dictionary-fa): ship the Apache-2.0 license text in the package - #22
Merged
Merged
Conversation
The Persian dictionary's release zip carried only main.js and the two Hunspell files. Its LICENSE was a short Apache notice with no license text and was not in the manifest's files, so recipients got no copy of the license, which Apache-2.0 section 4(a) requires. - LICENSE now follows the layout of the German and Spanish packages: the Lilak notice, naming the copyright holder as the header of assets/fa.aff does, then the full Apache License 2.0 text (the apache.org LICENSE-2.0.txt, byte for byte). - manifest.json lists LICENSE in files, so the release zip includes it. - Version 1.0.1 in manifest.json and plugin.json. packageUrl and sha256 keep pointing at the published 1.0.0 zip until the release job rewrites them, as with the Hello Status 1.1.0 bump. - The README links the 1.0.1 release and points at LICENSE. - A test fails when any official dictionary's manifest leaves LICENSE out of files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The official Persian dictionary's package ships without its license. The release zip holds only
main.js,assets/fa.affandassets/fa.dic, and the folder'sLICENSEwas a short Apache notice with no license text. Apache-2.0 section 4(a) requires giving recipients a copy of the license, so this brings the Persian package in line with how #21 ships German and Spanish.Changes
plugins/com.glyph.dictionary-fa/LICENSE: the section layout of the German and Spanish packages. First the Lilak notice, naming the copyright holder as the header ofassets/fa.affdoes (upstream's ownLICENSEleaves the name blank, which the old file copied), then a line saying the package distributes the data under Apache-2.0, then the full Apache License 2.0 text. That text is the apache.orgLICENSE-2.0.txtbyte for byte (md53b83ef96387f14655fc854ddc3c6bd57, the same bytes as the copies in several packages on disk; the copy intypescriptis reflowed and lacks the appendix, so it was not used).manifest.json:LICENSEadded tofiles, so the release zip carries it.manifest.jsonandplugin.json.packageUrlandsha256keep pointing at the published 1.0.0 zip, as the Hello Status 1.1.0 bump did in fix(hello-status): match the registration to the manifest and gate drift in CI #8: the release job rewrites both after merge, and until then the index still names a zip that verifies.README.md: the package link points at the 1.0.1 release, and the license mention points atLICENSE.scripts/dictionaries.test.mjs: a test per official dictionary that fails when its manifest leavesLICENSEout offiles.index.json,index/language.jsonanddocs/plugin-catalog.mdregenerated withnode scripts/build-index.mjs.Testing
npm ci --ignore-scripts && node --test: 36 passing (the release-official suite skips on Windows and runs in the Smoke job).LICENSEremoved from the Persian manifest, the new test fails forcom.glyph.dictionary-faonly.node scripts/check-plugins.mjspasses, and a freshscripts/build-index.mjsleaves the committed index unchanged.LICENSEhashes to the canonicalLICENSE-2.0.txtdigest above.