Skip to content

One lease comment per claim costs a comment on every item on every run #69

Open

Description

@glennfaison

Category: debt
Area: Protocol (agent-workflow-protocol/scripts/lib.sh, claim)
Impact: Every claim posts a new marker comment, including a claim that ends in noop. An item that goes through a few steps collects many comments that nobody reads and that notify everyone subscribed.
Confidence: traced

Problem

claim posts a lease marker comment each time and renew posts another. An issue that is triaged, implemented and settled collects at least one lease comment per step and per retry. A noop (claimed, nothing to do) leaves a comment that carries no information.

Cost of leaving it

Notification noise on every watched issue and PR, longer threads for the model to read on each later step (every comment is read, by the Trust rule), and more for a human to scroll past. #51 stopped the worst repeat (a PR waiting on the merge lane), so what remains is one per real claim.

Where

skills/meta/agent-workflow-protocol/scripts/lib.sh (claim, renew, lease_live), scripts/helpers.mjs (leaseComment, leaseState), and the Leases and Markers sections of the protocol.

Done when

Claiming an item that already has this step's marker comment edits that comment instead of adding one, lease_live still reads the newest trusted marker, and a test shows an item taken through three claims has one lease comment. The tests for expiry and trust (tests/lib.test.sh, tests/helpers.test.mjs) pass unchanged.

Suggested direction

Editing a comment needs the comment's id, so claim would look for its own earlier marker (author is the agent, marker matches the step) and PATCH it. Check that the edit time cannot be mistaken for the marker's expires, which is inside the body.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions