Repository navigation
fix: resolve Windows workspace launcher shims - #2545
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Closes #2544 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
🟡 Impact Analysis — PR #2545Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (2 files)
squad-sdk (1 file)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🛫 PR Readiness Check
PR Scope: 📦🔧 Mixed (product + infrastructure)
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 4 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 1 check(s) still running |
Files Changed (4 files, +62 −6)
| File | +/− |
|---|---|
.changeset/fix-windows-workspace-shim.md |
+6 −0 |
packages/squad-sdk/src/client/adapters/claude-plugin.ts |
+3 −2 |
plugins/squad/scripts/squad.mjs |
+3 −2 |
test/launcher-argv.test.ts |
+50 −2 |
Total: +62 −6
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the Windows workspace-local shim resolution changes.
No open issues 🎉
What changed in this PR
Fixes Windows workspace-local shim resolution for the generated repository launcher and Claude plugin, addressing #2544 while preserving shell-free argument forwarding and global npm support.
Changes:
- Resolves Squad and npx shims in
node_modules/.binto sibling package entry points. - Adds Windows regression coverage for PATH discovery, explicit shims, outdated CLI fallback, npx, and argument preservation.
- Regenerates the plugin launcher and adds patch changesets for the CLI and SDK.
| File | Description |
|---|---|
test/launcher-argv.test.ts |
Adds workspace shim resolution and argument-preservation tests. |
plugins/squad/scripts/squad.mjs |
Updates the generated plugin launcher’s shim resolution. |
packages/squad-sdk/src/client/adapters/claude-plugin.ts |
Corrects workspace package paths in the launcher generator. |
.changeset/fix-windows-workspace-shim.md |
Records CLI and SDK patch releases for the fix. |
Review effort: Balanced (adaptive)
Closes #2544 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix Windows workspace-local Squad and npx shim resolution in both the generated repository launcher and the Claude plugin launcher.
Why
Closes #2544. A workspace
.bin\squad.cmdwas incorrectly resolved beneath.bin\node_modules, preventing thesquad_statebridge andsquad doctorfrom starting.How
Resolve
.binshims against their sibling packages while retaining global npm layout and shell-free argument forwarding. Regenerate the plugin and cover PATH, explicit shim, outdated CLI fallback, npx, and argument preservation.npx changeset add/.changeset/*.md, directCHANGELOG.mdentry for maintainers, orskip-changeloglabel for no user-facing changes)PR Readiness Checklist
Branch & Commit
dev(notmain)dev(git fetch upstream && git rebase upstream/dev)git diff --cached --stat)Build & Test
npm run buildpassesnpm testpasses (all tests green)npm run lintpasses (type check clean)npm run lint:eslintpassesWindows x64, Node 26:
$env:SKIP_BUILD_BUMP='1'; npm run build: passed.npx vitest run test\launcher-argv.test.ts test\portable-launch.test.ts test\claude-plugin.test.ts test\ux-gates.test.ts test\acceptance\hostile.test.ts: passed, 79 passed, 6 skipped, 2 todo.npx vitest run test\launcher-argv.test.ts: passed, 9 tests, including the added explicit-shim case.npx vitest run test\cli\upgrade-portability.test.ts test\cli\init-upgrade-parity.test.ts --testTimeout 60000 --no-file-parallelism --silent: passed, 30 tests. The initial default-timeout run timed out on this Windows machine.npm run lint: passed.npx eslint packages\squad-sdk\src\client\adapters\claude-plugin.ts test\launcher-argv.test.ts: passed with 5 pre-existing warnings, no errors.node scripts\build-claude-plugin.mjs --check: passed.An isolated fresh init and an upgrade from a deliberately broken old managed launcher both passed the 15-tool
squad_statedoctor probe with a workspace shim on PATH, while preserving a user file.Changeset
npx changeset add(ifpackages/squad-sdk/src/orpackages/squad-cli/src/changed)CHANGELOG.mdentry (maintainers only — write-protected for external contributors)skip-changeloglabel applied (if no user-facing changes)Docs
No new capability or setup instructions; this repairs existing behavior.
Exports
N/A: no new modules or exports.
Breaking Changes
None.
Waivers
Full
npm testand fullnpm run lint:eslintwere not run locally; CI validation is pending. No waiver requested.