Clarify symlink behavior for repository file writes - #3071
Open
theinfosecguy wants to merge 2 commits into
Open
Conversation
theinfosecguy
marked this pull request as ready for review
August 14, 2026 15:26
SamMorrowDrums
force-pushed
the
fix-symlink-file-write-safety
branch
from
August 18, 2026 22:08
9138f5f to
c8f6977
Compare
Detect existing symlinks through the Git tree and require an explicit opt-in before changing their targets. Return the resolved repository target so callers can safely update the linked file instead. Refs github#2997 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SamMorrowDrums
force-pushed
the
fix-symlink-file-write-safety
branch
from
August 18, 2026 22:09
c8f6977 to
afd1d52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies that
get_file_contentsmay follow a symbolic link while repository file writes operate on exact Git paths. Adds guidance for distinguishing updates to linked content from changes to the link itself.Why
Fixes #2997.
A read can return the linked file's contents, but writing to the same path can rewrite or replace the symbolic link. The existing tool guidance did not explain this difference.
What changed
create_or_update_file.pathandpush_files.files[].path.MCP impact
Only descriptions and server instructions changed. Input shapes, handlers, and API call sequences remain unchanged.
Prompts tested (tool changes only)
tools/listoutput, and the existing handler workflows were verified locally.Security / limits
No authentication, permission, data exposure, or resource-limit behavior changed.
Tool renaming
Lint & tests
./script/lint./script/testAdditional validation included tool snapshot tests, repeated race-enabled edge-case tests, and
git diff --check.Docs