Skip to content

chore: Remove outdated experimental options - #7257

Open
sentrivana wants to merge 4 commits into
major/3.0from
ivana/major/drop-experimental-options
Open

chore: Remove outdated experimental options#7257
sentrivana wants to merge 4 commits into
major/3.0from
ivana/major/drop-experimental-options

Conversation

@sentrivana

@sentrivana sentrivana commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Description

Removed a handful of experimental options. Most of them now have a top-level counterpart.

I left some still in:

  • record_sql_queries: This should probably be removed once data collection is out out.
  • trace_lifecycle: I'd remove this when we remove the top-level trace_lifecycle at a later point.
  • transport options: keeping these for now
  • continuous profiler start: no top-level counterpart

Issues

Closes https://linear.app/getsentry/issue/PY-1924/remove-experimental-options

@linear-code

linear-code Bot commented Aug 26, 2026

Copy link
Copy Markdown

PY-1924

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

110090 passed | ⏭️ 5428 skipped | Total: 115518 | Pass Rate: 95.3% | Execution Time: 378m 19s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -8883
Passed Tests 📉 -7577
Failed Tests 📉 -2
Skipped Tests 📉 -1304

➖ Removed Tests (2)

View removed tests
  • test_continuous_profiler_auto_start_and_stop_sampled[non-experiment-gevent]
    • File: tests.profiler.test_continuous_profiler
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-gevent]
    • File: tests.profiler.test_continuous_profiler

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2270 uncovered lines.
✅ Project coverage is 90.51%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.22%    90.51%    +0.29%
==========================================
  Files          193       185        -8
  Lines        25435     23908     -1527
  Branches      9346      8808      -538
==========================================
+ Hits         22947     21638     -1309
- Misses        2488      2270      -218
- Partials      1434      1380       -54

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review August 26, 2026 13:18
@sentrivana
sentrivana requested a review from a team as a code owner August 26, 2026 13:18

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dff8477. Configure here.

Comment thread sentry_sdk/consts.py
"transport_http2": Optional[bool],
"transport_async": Optional[bool],
"before_send_log": Optional[Callable[[Log, Hint], Optional[Log]]],
"before_send_metric": Optional[Callable[[Metric, Hint], Optional[Metric]]],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental max_spans option not fully removed

Medium Severity

The experimental max_spans option was dropped from the Experiments type and documented as removed, but start_transaction still reads _experiments.max_spans when sizing the span recorder. Existing tests still set that experiment, so the option continues to work at runtime even though the public API no longer includes it. Unlike before_send_log, before_send_metric, ignore_spans, and before_send_span, this lookup was not updated.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dff8477. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine; all transaction code will be removed on this branch eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant