chore: Remove outdated experimental options - #7257
Conversation
Codecov Results 📊✅ 110090 passed | ⏭️ 5428 skipped | Total: 115518 | Pass Rate: 95.3% | Execution Time: 378m 19s 📊 Comparison with Base Branch
➖ Removed Tests (2)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2270 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.22% 90.51% +0.29%
==========================================
Files 193 185 -8
Lines 25435 23908 -1527
Branches 9346 8808 -538
==========================================
+ Hits 22947 21638 -1309
- Misses 2488 2270 -218
- Partials 1434 1380 -54Generated by Codecov Action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dff8477. Configure here.
| "transport_http2": Optional[bool], | ||
| "transport_async": Optional[bool], | ||
| "before_send_log": Optional[Callable[[Log, Hint], Optional[Log]]], | ||
| "before_send_metric": Optional[Callable[[Metric, Hint], Optional[Metric]]], |
There was a problem hiding this comment.
Experimental max_spans option not fully removed
Medium Severity
The experimental max_spans option was dropped from the Experiments type and documented as removed, but start_transaction still reads _experiments.max_spans when sizing the span recorder. Existing tests still set that experiment, so the option continues to work at runtime even though the public API no longer includes it. Unlike before_send_log, before_send_metric, ignore_spans, and before_send_span, this lookup was not updated.
Reviewed by Cursor Bugbot for commit dff8477. Configure here.
There was a problem hiding this comment.
This is fine; all transaction code will be removed on this branch eventually.


Description
Removed a handful of experimental options. Most of them now have a top-level counterpart.
I left some still in:
record_sql_queries: This should probably be removed once data collection is out out.trace_lifecycle: I'd remove this when we remove the top-leveltrace_lifecycleat a later point.Issues
Closes https://linear.app/getsentry/issue/PY-1924/remove-experimental-options