Skip to content

fix(aiohttp): Gate request body collection on data_collection experiment - #7249

Merged
ericapisani merged 1 commit into
masterfrom
py-2419-request-body-aiohttp
Aug 26, 2026
Merged

fix(aiohttp): Gate request body collection on data_collection experiment#7249
ericapisani merged 1 commit into
masterfrom
py-2419-request-body-aiohttp

Conversation

@ericapisani

Copy link
Copy Markdown
Member

Only attach the raw request body when data collection is disabled or "incoming_request" is included in the http_bodies experiment option. Previously the body was always attached regardless of this setting.

Refs PY-2419
Refs #6283

Only attach the raw request body when data collection is disabled or
"incoming_request" is included in the http_bodies experiment option.
Previously the body was always attached regardless of this setting.

Refs PY-2419
Refs #6283
@ericapisani
ericapisani requested a review from a team as a code owner August 25, 2026 19:10
@linear-code

linear-code Bot commented Aug 25, 2026

Copy link
Copy Markdown

PY-2419

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

117724 passed | ⏭️ 6732 skipped | Total: 124456 | Pass Rate: 94.59% | Execution Time: 430m 50s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +55
Passed Tests 📈 +57
Failed Tests 📉 -2
Skipped Tests

➖ Removed Tests (2)

View removed tests
  • test_continuous_profiler_auto_start_and_stop_sampled[non-experiment-gevent]
    • File: tests.profiler.test_continuous_profiler
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-gevent]
    • File: tests.profiler.test_continuous_profiler

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2486 uncovered lines.
✅ Project coverage is 90.23%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.22%    90.23%    +0.01%
==========================================
  Files          193       193         —
  Lines        25435     25439        +4
  Branches      9346      9350        +4
==========================================
+ Hits         22947     22953        +6
- Misses        2488      2486        -2
- Partials      1434      1433        -1

Generated by Codecov Action

@ericapisani
ericapisani merged commit 9820bf9 into master Aug 26, 2026
144 checks passed
@ericapisani
ericapisani deleted the py-2419-request-body-aiohttp branch August 26, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants