Next Python SDK major - #5005
Draft
sentrivana wants to merge 125 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5005 +/- ##
===========================================
+ Coverage 70.55% 83.76% +13.21%
===========================================
Files 180 180
Lines 18077 18080 +3
Branches 3008 3009 +1
===========================================
+ Hits 12754 15145 +2391
+ Misses 4432 1943 -2489
- Partials 891 992 +101
|
Closed
Contributor
Codecov Results 📊✅ 111241 passed | ⏭️ 5428 skipped | Total: 116669 | Pass Rate: 95.35% | Execution Time: 375m 5s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 90.64%. Project has 2228 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.23% 90.64% +0.41%
==========================================
Files 193 185 -8
Lines 25482 23811 -1671
Branches 9384 8788 -596
==========================================
+ Hits 22994 21583 -1411
- Misses 2488 2228 -260
- Partials 1431 1362 -69Generated by Codecov Action |
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Add `UnraisablehookIntegration` to the default integrations list.
Stop raising exceptions `from None` in the ASGI and asyncio integrations. Closes #5624
Remove everything hub related, including all sorts of compatibility shims around hubs/scopes. Also remove deprecated session methods. `configure_scope` and `push_scope` removal coming in a future PR. #### Issues Closes #5001
The integration requires additional configuration which should be intentional on the user's part. #### Issues Closes #4993
- Remove everything in `integrations/opentelemetry` (`SentrySpanProcessor`, `SentryPropagator`, etc.) - Remove associated test files and CI config - Move old propagator functions and consts that we were using in `OTLPIntegration` to the OTLP propagator directly - Remove `instrumenter` Note: `NoOpSpan` was not removed because it makes mypy blow up. Not worth the effort as we'll anyway get rid of it when dropping transaction based tracing. #### Issues Closes #6932
### Description The API is deprecated and slated for removal in 3.0. #### Issues Closes #5019 #### Reminders - Please add tests to validate your changes, and lint your code using `uv run ruff`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
### Description Remove the deprecated API. #### Issues Closes #5018
### Description Most of the entries in our extras list serve as a way to communicate/enforce the lower boundary of the respective framework that we support. This creates a parallel system to the version checks we already have in each integration. Some extras, however, define extra dependencies or specific extras that are required for an integration to work correctly (e.g. the Flask integration needs `blinker` to work properly). In that case, keep the extra. #### Issues Closes #6259
The options were deprecated with 2fef9bc.
### Description The timeout in the AWS Lambda (and GCP, by extension) timeout warning is wrong, remove it and slightly rephrase. This is on the new major branch since it breaks grouping. (Even just removing the number from the original message, without modifying it further, causes regrouping. Since that's the case I took the liberty to update the message a bit more.) Original POTel PR: #4671 #### Issues Closes https://linear.app/getsentry/issue/PY-1937/change-aws-lambda-timeout-message #### Reminders - Please add tests to validate your changes, and lint your code using `uv run ruff`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
sentrivana
added a commit
that referenced
this pull request
Aug 26, 2026
Originally raised by a bot [here](#5005 (comment)): the `parse_version` function parses version strings as is (e.g. 3.1 becomes `(3, 1)`). We use these parsed version tuples in integrations to compare the installed version against the minimum (defined in `integrations/__init__.py`). The minimum versions are often three-part, e.g. `(3, 1, 0)`. This means that we can mistakenly consider a valid version to be below the minimum, because in pure tuple terms, `(3, 1) < (3, 1, 0)` is true. This can also happen in reverse (package version has three parts, while our min version boundary has two). In this PR, we make the internal version comparison work as expected regardless of mismatches in the length of the version strings/tuples.
Comment on lines
+109
to
123
| with sentry_sdk.traces.start_span( | ||
| name="unknown arq task", | ||
| status="ok", | ||
| op=OP.QUEUE_TASK_ARQ, | ||
| source=TransactionSource.TASK, | ||
| origin=ArqIntegration.origin, | ||
| ) | ||
|
|
||
| with sentry_sdk.start_transaction(transaction) as span: | ||
| attributes={ | ||
| "sentry.op": OP.QUEUE_TASK_ARQ, | ||
| "sentry.origin": ArqIntegration.origin, | ||
| "sentry.segment.name.source": SegmentNameSource.TASK, | ||
| SPANDATA.MESSAGING_MESSAGE_ID: job_id, | ||
| }, | ||
| parent_span=None, | ||
| ) as span: | ||
| if self.queue_name is not None: | ||
| span.set_data(SPANDATA.MESSAGING_DESTINATION_NAME, self.queue_name) | ||
| span.set_attribute( | ||
| SPANDATA.MESSAGING_DESTINATION_NAME, self.queue_name | ||
| ) | ||
| return await old_run_job(self, job_id, score) |
Contributor
There was a problem hiding this comment.
Failed ARQ task spans keep status ok under span streaming
After switching run_job to streamed spans, _capture_exception still only sets status via scope.transaction, which is always None in streaming mode—so failed task segments stay ok unless the exception happens to escape ARQ. Update _capture_exception to set scope.streamed_span.status (as Celery does) and assert error status in the failure tests.
Evidence
- This hunk makes
traces.start_span(..., parent_span=None)the only task path in_sentry_run_job. _capture_exceptionstill doesif scope.transaction is not None: scope.transaction.set_status(...).- In streaming mode,
Scope.transactionreturnsNone, so that status update is a no-op. - ARQ job failures are typically handled inside
Worker.run_job, so the streamed span__exit__often never sees the exception to markerroritself. - Celery already maps this via
scope.streamed_span.status; ARQ tests assert failure events but not task-span status.
Identified by Warden · code-review, find-bugs · LZ3-SDG
### Description Getting rid of custom APIs. `update_current_span` never worked with span streaming anyway. #### Issues Part of https://linear.app/getsentry/issue/PY-2623/drop-custom-apis Part of #6894 #### Reminders - Please add tests to validate your changes, and lint your code using `uv run ruff`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
### Description Many of the `set_tag` calls were only present in non-span-streaming branches, which will be completely removed anyway, and we've already migrated those tags, if applicable, to span attributes in the scope of span first. #### Issues Closes https://linear.app/getsentry/issue/PY-1940/remove-tags-auto-set-by-the-sdk
### Description Get the logging integration into shape now that Sentry Logs is a first-class feature. The idea is to make Logs the primary feature the integration offers, with capturing events an optional add-on. High-level overview of the changes: - The integration has to be **enabled explicitly** by the user. It's not auto-enabled anymore. - **Sentry logs related options and features get more generic sounding names**. - For instance, `level` (before: `sentry_logs_level`), `ignore_logger` (before: `ignore_logger_for_sentry_logs`) now set the Sentry logs level and Sentry logs denylist, respectively. - Existing secondary features with previously generic names get specialized names (`level` -> `breadcrumb_level`, `ignore_logger` -> `ignore_logger_for_events`). - **Capturing Sentry logs is on by default** when the integration is enabled. - **Event capture is off by default**, but can be turned on via an option. Breadcrumb capture is still on by default. - The **`capture_sentry_logs` option is gone completely**. Since logs instrumentation is now on by default, and the `level` option exists, it was superfluous. Capturing logs can still be opted out of by setting `level=None`. Collateral: - Updated unrelated tests that were implicitly relying on default behavior of the logging integration #### Issues Closes #7246 Closes https://linear.app/getsentry/issue/PY-2739/update-logging-integration
### Description Get the Loguru integration into shape now that Sentry Logs is a first-class feature. The idea is to make Logs the primary feature the integration offers, with capturing events an optional add-on. High-level overview of the changes: - The integration has to be **enabled explicitly** by the user. It's not auto-enabled anymore. - **Sentry logs related options and features get more generic sounding names**. - For instance, `level` (before: `sentry_logs_level`) now sets the Sentry logs level. - Existing secondary features with previously generic names get specialized names (`level` -> `breadcrumb_level`). - **Capturing Sentry logs is on by default** when the integration is enabled. - **Event capture is off by default**, but can be turned on via an option. Breadcrumb capture is still on by default. - The **`capture_sentry_logs` option is gone completely**. Since logs instrumentation is now on by default, and the `level` option exists, it was superfluous. Capturing logs can still be opted out of by setting `level=None`. #### Issues Closes #7247 Closes https://linear.app/getsentry/issue/PY-2740/update-loguru-integration
Changes: - remove deprecated `max_spans` option of `LangchainIntegration` - remove deprecated `sentry_sdk.init()` context manager - remove deprecated `configure_debug_hub` - remove deprecated `Baggage.from_options()` - remove deprecated `Transport.capture_event()` - remove deprecated `FunctionTransport` - the `Scope.trace_propagation_meta` function no longer accepts a `span` as argument - remove deprecated direct assignment to `Scope.level` - remove deprecated direct assignment to `Scope.user` - remove deprecated `Scope.iter_headers` Closes https://linear.app/getsentry/issue/PY-1935/drop-deprecated-stuff
…ng` for everything else) (#7268) - Add a helper to use for deprecation warnings, specifically, that uses `warnings.warn()` - For everything but deprecation warnings, use `logger.warning()` Closes https://linear.app/getsentry/issue/PY-1934/use-warningswarn-for-deprecations-and-loggerwarning-for-everything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're preparing our next major on this branch.
The project is tracked in Linear. If you don't have access, we'll try to tag issues belonging to the project with the
SDK3.0 label on GitHub so that you can follow along.Notable changes
Context
You might have read this announcement about us discontinuing work on a 3.0. This is referring to the work done on the
potel-basebranch, which included two types of changes: a huge refactor of our tracing code on the one hand, and various unrelated changes, improvements and fixes on the other. We're dropping the huge refactor part, and only porting the rest, to a new branch and eventually a new 3.0 release.Changes