Repository navigation
fix(android): Read APK manifest and resources.arsc from the root only - #725
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Android only reads AndroidManifest.xml and resources.arsc from the APK root. Searching the whole tree failed on APKs where a library ships a stray nested copy, e.g. deeplinkdispatch/AndroidManifest.xml. Fixes LAUNCHPAD-9R Co-Authored-By: Hector Dearman <hector.dearman@sentry.io>
Contributor
📲 Install BuildsiOS
Android
|
Contributor
Size Analysis2 components analyzed iOS Builds
Android Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APK.get_manifest()andget_resource_tables()searched the whole extracted APK forAndroidManifest.xml/resources.arscand raised if they found more than one. Some APKs ship a stray library copy (seen in prod:deeplinkdispatch/AndroidManifest.xmlnext to the real root manifest), so preprocessing failed withMultiple AndroidManifest.xml files found in APK.Android only reads both files from the APK root, so read them from there and ignore any nested copies.
Fixes LAUNCHPAD-9R
Fixes LAUNCHPAD-9Q
via Hector.
--
View Junior Session [Sentry]