Repository navigation
build(deps): Upgrade objectstore-client to 0.3.0 - #720
Merged
Merged
Conversation
objectstore-client 0.3.0 splits the signing key from the token policy: TokenGenerator now wraps a SecretKey(kid, secret_key) instead of taking the key fields directly. Co-Authored-By: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
Contributor
Size Analysis1 component analyzed, 1 component processing iOS Builds
Android Builds
|
Contributor
📲 Install BuildsiOS
Android
|
lcian
marked this pull request as ready for review
October 27, 2026 12:48
lcian
enabled auto-merge (squash)
October 27, 2026 12:49
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9ed29e6. Configure here.
NicoHinderling
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
objectstore-clientfrom 0.1.10 to 0.3.0 and adapts to its breaking auth change.In 0.3.0,
SecretKey(kid, secret_key)only holds the signing key, andTokenGenerator(key, expiry_seconds, permissions)wraps it with the token defaults.create_objectstore_clientnow passesSecretKey(key_id, secret_key)as the first argument. The expiry and permissions stay the same.The minimum version moves from
>=0.1.0to>=0.3.0, because the new constructor call doesn't work with older clients. Launchpad doesn't use any of the other APIs that changed between 0.1.10 and 0.3.0.via @lcian.
--
View Junior Session [Sentry]