Repository navigation
Conversation
8c33413 to
e441e0e
Compare
Currently, stacker converts the base part of a "FROM base AS name"
found in a dockerfile to stacker's from directive with type:docker
and url:docker.
However, the base could be a build stage in the current session.
In that case, stacker's from directive should be type:built and
tag:<something> instead.
Signed-off-by: Joy Latten <joylatten@geico.com>
e441e0e to
0107837
Compare
Signed-off-by: Joy Latten <joylatten@geico.com>
0107837 to
a15b729
Compare
Signed-off-by: Joy Latten <joylatten@geico.com>
|
This PR is for internal review only. It was opened back in September believing mirrors were not ready for general use. It was also opened in response to feedback for upstreamed PR. (See My intentions are that once reviewed, I will only push the testcase commit(s) to the already upstreamed PR. This PR will then be closed without merging, since only for internal review. Note: Currently, the mirror fails to sync with upstream, so am asking for internal review here. |
PinkMonstera
left a comment
PinkMonstera
left a comment
There was a problem hiding this comment.
No obvious security concerns. SSCS approved
fusion94
left a comment
fusion94
left a comment
There was a problem hiding this comment.
I'm approving but there is a correctness issue that will probably need to be addressed in the future:
Plain FROM <stage> with no AS isn't handled. The new check only runs in the len(cmd.Value) == 3 branch (convert.go:91). This pattern is very common:
FROM golang AS build
...
FROM build
The final stage still gets type: docker, url: docker://build, which fails at build time. Most real multi-stage Dockerfiles end with a final stage that has no AS, so the fix misses the most common case.
|
Hi @fusion94, |
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.