Let an ordering index scan hand its ORDER BY value to the target list [cf-7392]

.clangd

@@ -0,0 +1,43 @@
+Diagnostics:
+  MissingIncludes: None
+InlayHints:
+  Enabled: true
+  ParameterNames: true
+  DeducedTypes: true
+CompileFlags:
+  CompilationDatabase: build/       # Search build/ directory for compile_commands.json
+  Remove: [ -Werror ]
+  Add:
+  - -DDEBUG
+  - -DLOCAL
+  - -DPGDLLIMPORT=
+  - -DPIC
+  - -O2
+  - -Wall
+  - -Wcast-function-type
+  - -Wconversion
+  - -Wdeclaration-after-statement
+  - -Wendif-labels
+  - -Werror=vla
+  - -Wextra
+  - -Wfloat-equal
+  - -Wformat-security
+  - -Wimplicit-fallthrough=3
+  - -Wmissing-format-attribute
+  - -Wmissing-prototypes
+  - -Wno-format-truncation
+  - -Wno-sign-conversion
+  - -Wno-stringop-truncation
+  - -Wno-unused-const-variable
+  - -Wpointer-arith
+  - -Wshadow
+  - -Wshadow=compatible-local
+  - -fPIC
+  - -fexcess-precision=standard
+  - -fno-strict-aliasing
+  - -fvisibility=hidden
+  - -fwrapv
+  - -g
+  - -std=c11
+  - -I.
+  - -I../../../../src/include

.envrc

@@ -0,0 +1,10 @@
+# Inherit shared CFLAGS from ~/ws/postgres/.envrc, load this worktree's
+# flake, then layer the postgres agent context (helpers need flake's PATH +
+# write into this worktree's dir).
+source_up
+watch_file flake.nix
+use flake
+pg_cflags
+use project_steering postgresql aws c
+use git_policy allow-force-push
+use project_mcp postgresq

.gdbinit

@@ -0,0 +1,156 @@
+# HOT Indexed Updates — GDB breakpoints for code review
+#
+# Usage:  gdb -x .gdbinit <postgres-binary>
+# Or from gdb:  source .gdbinit
+#
+# These breakpoints cover the major code paths introduced or modified by
+# the HOT indexed updates patch series.  They are organized by subsystem
+# to make it easy to enable/disable groups during debugging.
+#
+# Tip: to skip to a specific subsystem, disable all then enable selectively:
+#   disable breakpoints
+#   enable 1 2 3          # just the update-decision group
+
+# =========================================================================
+# 1. UPDATE DECISION — heap_update() HOT/HOT-indexed/non-HOT choice
+#    src/backend/access/heap/heapam.c
+# =========================================================================
+
+# Main entry: heap_update
+break heapam.c:3210
+
+# HOT decision block: pure HOT vs HOT indexed vs non-HOT
+# Line 4019: pure HOT (no indexed columns changed)
+# Line 4024: HOT indexed path (non-catalog, some indexed columns changed)
+# Line 4031: predict augmented tuple size
+# Line 4033: size+space check before creating augmented tuple
+break heapam.c:4019
+break heapam.c:4024
+break heapam.c:4033
+
+# Set HEAP_INDEXED_UPDATED flag on new tuple before page insertion
+break heapam.c:4101
+
+# Restore HEAP_INDEXED_UPDATED on old tuple (only if it previously had it)
+break heapam.c:4147
+
+# =========================================================================
+# 2. TUPLE CREATION — building the augmented tuple with embedded bitmap
+#    src/backend/access/heap/heapam.c
+# =========================================================================
+
+# Predict augmented tuple size (returns 0 if t_hoff would overflow)
+break heap_hot_indexed_tuple_size
+
+# Create augmented tuple with embedded modified-column bitmap
+break heap_hot_indexed_create_tuple
+
+# Serialize Bitmapset into raw bytes in tuple header
+break heap_hot_indexed_serialize_bitmap
+
+# =========================================================================
+# 3. BITMAP UTILITIES — raw bitmap operations for chain following
+#    src/backend/access/heap/heapam.c
+# =========================================================================
+
+# Compute raw bitmap byte size from natts
+break heap_hot_indexed_bitmap_raw_size
+
+# Check if tuple header has room for bitmap between null bitmap and data
+break heap_hot_indexed_has_bitmap_space
+
+# Read HOT indexed bitmap from tuple header (returns Bitmapset)
+break heap_hot_indexed_read_bitmap
+
+# Fast overlap check: does tuple's raw bitmap overlap with indexed_attrs?
+break heap_hot_indexed_bitmap_overlaps_raw
+
+# OR a tuple's raw bitmap into an accumulator buffer
+break heap_hot_indexed_bitmap_or_raw
+
+# Check if accumulated raw bitmap overlaps with indexed_attrs
+break heap_hot_indexed_accum_overlaps
+
+# Merge bitmaps from dead tuples into a target tuple on the page
+break heap_hot_indexed_merge_bitmaps_raw
+
+# Deserialize raw bytes back to Bitmapset
+break heap_hot_indexed_deserialize_bitmap
+
+# =========================================================================
+# 4. INDEX SCAN — HOT chain following with stale-entry detection
+#    src/backend/access/heap/heapam_indexscan.c
+# =========================================================================
+
+# Main HOT chain search with indexed update awareness
+break heap_hot_search_buffer
+
+# Redirect-with-data: initialize bitmap accumulator from collapsed redirect
+break heapam_indexscan.c:182
+
+# Accumulate bitmap from INDEXED_UPDATED tuple in chain
+break heapam_indexscan.c:250
+
+# Stale entry detection: accumulated bitmap overlaps this index's attrs
+break heapam_indexscan.c:297
+
+# =========================================================================
+# 5. INDEX SCAN SETUP — indexed_attrs bitmap computation
+#    src/backend/access/index/indexam.c
+# =========================================================================
+
+# Compute indexed_attrs for HOT indexed update chain following
+break indexam.c:299
+
+# =========================================================================
+# 6. INDEX INSERTION — skip unchanged indexes for HOT indexed updates
+#    src/backend/executor/execIndexing.c
+# =========================================================================
+
+# Entry: insert/update index tuples
+break ExecInsertIndexTuples
+
+# Index skip decision: skip indexes whose attrs don't overlap modified set
+break execIndexing.c:370
+
+# =========================================================================
+# 7. PRUNING — chain collapsing and redirect-with-data
+#    src/backend/access/heap/pruneheap.c
+# =========================================================================
+
+# Main prune function
+break heap_page_prune_and_freeze
+
+# Per-chain pruning entry
+break heap_prune_chain
+
+# Chain collapsing: collect bitmaps from dead INDEXED_UPDATED intermediates
+break pruneheap.c:1802
+
+# OR dead tuple bitmaps into combined bitmap
+break pruneheap.c:1836
+
+# Record redirect-with-data for execute phase
+break pruneheap.c:1863
+
+# Execute phase: apply redirect-with-data entries on the page
+break pruneheap.c:1287
+
+# =========================================================================
+# 8. WAL REPLAY — recovery of HOT indexed updates
+#    src/backend/access/heap/heapam_xlog.c
+# =========================================================================
+
+# WAL replay for XLOG_HEAP2_INDEXED_UPDATE
+break heap_xlog_indexed_update
+
+# =========================================================================
+# 9. WAL LOGGING — writing HOT indexed update records
+#    src/backend/access/heap/heapam.c
+# =========================================================================
+
+# WAL logging for heap updates (handles indexed_update flag)
+break log_heap_update
+
+# Serialize redirect-with-data into WAL record (pruneheap.c)
+break pruneheap.c:2936

.github/workflows/fork-ocr-model-check.yml

@@ -0,0 +1,18 @@
+# Weekly check for a newer Claude Opus on Bedrock; opens/updates one issue here
+# when OCR_BEDROCK_MODEL is behind. Notify-only (GITHUB_TOKEN cannot write
+# Actions variables). Logic lives in gburd/ci-workflows.
+
+name: OCR model self-check
+
+on:
+  schedule:
+    - cron: '0 12 * * 1'   # Mondays 12:00 UTC
+  workflow_dispatch:
+
+jobs:
+  check:
+    uses: gburd/ci-workflows/.github/workflows/ocr-model-check.yml@v1
+    with:
+      aws_role_arn: ${{ vars.AWS_ROLE_ARN }}
+      aws_region: ${{ vars.AWS_REGION }}
+      bedrock_model: ${{ vars.OCR_BEDROCK_MODEL }}

.github/workflows/fork-ocr-review.yml

@@ -0,0 +1,43 @@
+# AI PR review (Claude Opus on Bedrock). Logic and review rules live in
+# gburd/ci-workflows so this fork's master carries a stub instead of ~1000
+# lines that have to be rebased onto upstream forever.
+#
+# Needs repo variables AWS_ROLE_ARN, AWS_REGION, OCR_BEDROCK_MODEL. Auth is
+# GitHub OIDC; no static AWS keys. See the ci-workflows README.
+
+name: OCR AI Review
+
+on:
+  pull_request:
+    # Note: no draft filter — drafts are reviewed too.
+    types: [opened, synchronize, reopened, ready_for_review]
+  issue_comment:
+    types: [created]
+  workflow_dispatch:
+    inputs:
+      pr_number:
+        description: 'PR number to review'
+        required: true
+        type: number
+
+# One review per PR; cancel superseded runs to save Bedrock spend.
+concurrency:
+  group: ocr-review-${{ github.event.pull_request.number || github.event.issue.number || github.event.inputs.pr_number }}
+  cancel-in-progress: true
+
+jobs:
+  review:
+    # Comment events only when the comment is on a PR and starts with the
+    # trigger keyword; PR events and manual dispatch always.
+    if: |
+      github.event_name == 'pull_request' ||
+      github.event_name == 'workflow_dispatch' ||
+      (github.event_name == 'issue_comment' && github.event.issue.pull_request &&
+        (startsWith(github.event.comment.body, '/open-code-review') ||
+         startsWith(github.event.comment.body, '@open-code-review') ||
+         startsWith(github.event.comment.body, '/pg-history')))
+    uses: gburd/ci-workflows/.github/workflows/ocr-review.yml@v1
+    with:
+      aws_role_arn: ${{ vars.AWS_ROLE_ARN }}
+      aws_region: ${{ vars.AWS_REGION }}
+      bedrock_model: ${{ vars.OCR_BEDROCK_MODEL }}

.github/workflows/fork-sync-upstream.yml

@@ -0,0 +1,48 @@
+# Keep this fork's master rebased on postgres/postgres master, carrying only
+# the fork-owned CI stubs (.github/workflows/fork-*.yml). The workflows they
+# call, and the OCR review rules, live in gburd/ci-workflows.
+#
+# Requires the SYNC_TOKEN secret: a PAT with repo+workflow scope. The default
+# GITHUB_TOKEN is not allowed to push commits that touch .github/workflows/,
+# and every commit we carry does.
+
+name: Sync from upstream
+
+on:
+  schedule:
+    - cron: '17 */3 * * *'
+  workflow_dispatch:
+
+concurrency:
+  group: fork-sync-upstream
+
+permissions:
+  contents: read
+
+jobs:
+  sync:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+          token: ${{ secrets.SYNC_TOKEN }}
+
+      - name: Rebase master onto upstream
+        run: |
+          set -euo pipefail
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          git remote add upstream https://github.com/postgres/postgres.git
+          git fetch --no-tags upstream master
+
+          # Master carries fork CI only. Anything else means work landed here
+          # that belongs on a branch; force-rebasing it on a timer would be wrong.
+          if git diff --name-only upstream/master...HEAD |
+               grep -v '^\.github/workflows/fork-'; then
+            echo "::error::master carries non-CI changes (listed above); move them to a branch"
+            exit 1
+          fi
+
+          git rebase upstream/master
+          git push --force-with-lease

contrib/btree_gist/expected/timestamp.out

@@ -89,3 +89,37 @@ SELECT a, a <-> '2004-10-26 08:55:08' FROM timestamptmp ORDER BY a <-> '2004-10-
  Mon Nov 29 20:12:43 2004 | @ 34 days 11 hours 17 mins 35 secs
 (3 rows)
 
+-- An ordering scan that hands an exact point distance to the target list
+-- while another ORDER BY key, here an interval, is of a by-reference type.
+CREATE TABLE timestamppt (p point, a timestamp);
+INSERT INTO timestamppt
+  SELECT point(i % 7, i % 11), '2004-10-26 08:55:08'::timestamp + i * interval '37 min'
+  FROM generate_series(1, 600) i;
+CREATE INDEX timestamppt_idx ON timestamppt USING gist (p, a);
+SET enable_indexonlyscan = off;
+EXPLAIN (VERBOSE, COSTS OFF)
+SELECT p <-> point(3, 4) AS d, a <-> '2004-10-26 08:55:08' AS da
+  FROM timestamppt
+  ORDER BY p <-> point(3, 4), a <-> '2004-10-26 08:55:08' LIMIT 3;
+                                                               QUERY PLAN                                                               
+----------------------------------------------------------------------------------------------------------------------------------------
+ Limit
+   Output: ((p <-> '(3,4)'::point)), ((a <-> 'Tue Oct 26 08:55:08 2004'::timestamp without time zone))
+   ->  Index Scan using timestamppt_idx on public.timestamppt
+         Output: ((p <-> '(3,4)'::point)), (a <-> 'Tue Oct 26 08:55:08 2004'::timestamp without time zone)
+         Order By: ((timestamppt.p <-> '(3,4)'::point) AND (timestamppt.a <-> 'Tue Oct 26 08:55:08 2004'::timestamp without time zone))
+         Order By Values Used: 1
+(6 rows)
+
+SELECT p <-> point(3, 4) AS d, a <-> '2004-10-26 08:55:08' AS da
+  FROM timestamppt
+  ORDER BY p <-> point(3, 4), a <-> '2004-10-26 08:55:08' LIMIT 3;
+ d |            da             
+---+---------------------------
+ 0 | @ 1 day 12 hours 23 mins
+ 0 | @ 3 days 11 hours 52 mins
+ 0 | @ 5 days 11 hours 21 mins
+(3 rows)
+
+RESET enable_indexonlyscan;
+DROP TABLE timestamppt;

contrib/btree_gist/sql/timestamp.sql

@@ -35,3 +35,21 @@ SELECT count(*) FROM timestamptmp WHERE a >  '2004-10-26 08:55:08'::timestamp;
 EXPLAIN (COSTS OFF)
 SELECT a, a <-> '2004-10-26 08:55:08' FROM timestamptmp ORDER BY a <-> '2004-10-26 08:55:08' LIMIT 3;
 SELECT a, a <-> '2004-10-26 08:55:08' FROM timestamptmp ORDER BY a <-> '2004-10-26 08:55:08' LIMIT 3;
+
+-- An ordering scan that hands an exact point distance to the target list
+-- while another ORDER BY key, here an interval, is of a by-reference type.
+CREATE TABLE timestamppt (p point, a timestamp);
+INSERT INTO timestamppt
+  SELECT point(i % 7, i % 11), '2004-10-26 08:55:08'::timestamp + i * interval '37 min'
+  FROM generate_series(1, 600) i;
+CREATE INDEX timestamppt_idx ON timestamppt USING gist (p, a);
+SET enable_indexonlyscan = off;
+EXPLAIN (VERBOSE, COSTS OFF)
+SELECT p <-> point(3, 4) AS d, a <-> '2004-10-26 08:55:08' AS da
+  FROM timestamppt
+  ORDER BY p <-> point(3, 4), a <-> '2004-10-26 08:55:08' LIMIT 3;
+SELECT p <-> point(3, 4) AS d, a <-> '2004-10-26 08:55:08' AS da
+  FROM timestamppt
+  ORDER BY p <-> point(3, 4), a <-> '2004-10-26 08:55:08' LIMIT 3;
+RESET enable_indexonlyscan;
+DROP TABLE timestamppt;