Repository navigation
MNT remove dead WebGL rendering code - #763
Draft
kroq-gar78 wants to merge 2 commits into
Draft
kroq-gar78 wants to merge 2 commits into
kroq-gar78 wants to merge 2 commits into
Conversation
VolumeSheets has never been instantiated anywhere in the repo's history.
The halo renderer (HALO_RENDER, cmap_quad) was an unfinished 2013 experiment, unreachable since the r69 rewrite, and its GLSL no longer compiled. ShadowTex was never instantiated. setHalo() stays: it builds the surface's live mesh.
Contributor
Author
|
Note: merge this after #762 so we ensure the shaders don't break. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deletes rendering code that is no longer used:
HALO_RENDERinsurface_pixel,Shaders.cmap_quad,decode_float_vec2, and the commented-out wiring inmriview_surface.jsandaxes3d.js): an unfinished 2013 experiment, unreachable since the Three.js r69 rewrite in 2014.VolumeSheets(mriview_surface.js): never instantiated anywhere in the repo's history.shadowtex.js: never instantiated. Onlysimple.htmlloaded it.setHalo()stays: despite the name, it builds the surface's live mesh. Renaming may need more refactoring, so it is out of the scope of this PR.Testing
Follow-ups
simple.htmlwas already broken: it loads files that don't exist.