Skip to content

feat: update models vrs 2.1.1-ballot.2026-09.1 - #658

Merged
korikuzma merged 13 commits into
vrs/2.1.0from
ballot-updates
Sep 29, 2026
Merged

korikuzma merged 13 commits into
vrs/2.1.0from
ballot-updates

Conversation

@korikuzma

@korikuzma korikuzma commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • update models vrs 2.1.1-ballot.2026-09.1 and gkm-core 1.3.0-ballot.2026-09.1
    • Added _abstract classvar
    • GKS -> GKM (deprecating classes that start with GKS)
    • Adds missing RelativeAllele to Variation root

Schema changes

note: Use /json rather than *-source.yaml

* core version: 1.3.0-ballot.2026-09.1
@korikuzma korikuzma self-assigned this Sep 24, 2026
@korikuzma korikuzma added the enhancement New feature or request label Sep 24, 2026
@korikuzma
korikuzma requested a review from a team as a code owner September 24, 2026 18:59
@korikuzma korikuzma added the priority:high High priority label Sep 24, 2026
@korikuzma
korikuzma requested a review from a team as a code owner September 24, 2026 18:59
@korikuzma
korikuzma marked this pull request as draft September 24, 2026 21:15
@korikuzma korikuzma changed the title feat!: update models vrs 2.1.1-ballot.2026-09.1 feat: update models vrs 2.1.1-ballot.2026-09.1 Sep 25, 2026
@korikuzma
korikuzma marked this pull request as ready for review September 25, 2026 14:57

@larrybabb larrybabb left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a claude review

Findings

  1. (Medium) packaging is imported but not a declared dependency. metadata.py:6 adds from packaging.version import Version at module top level, but packaging isn't in pyproject.toml's runtime dependencies (pydantic, bioutils, requests, canonicaljson, typing-extensions). I confirmed in the venv that packaging is Required-by only dev/notebook tools (pytest, sphinx, jupyter) — none of the runtime deps pull it. A minimal pip install ga4gh.vrs[extras] could therefore fail at import ga4gh.core.metadata with ModuleNotFoundError. In practice packaging is near-ubiquitous, so it likely won't bite most users and CI never sees it — but for a reference library an undeclared top-level import is a real gap.

    • Fix: add "packaging" to dependencies, or avoid the dep entirely by comparing pydantic.VERSION (a tuple-parseable string pydantic already exposes).

Comment thread src/ga4gh/core/metadata.py Outdated
korikuzma and others added 2 commits September 28, 2026 04:44
Co-authored-by: Larry Babb <lbabb@broadinstitute.org>
@korikuzma
korikuzma requested a review from larrybabb September 28, 2026 08:47
Comment thread tests/validation/test_model_metadata.py Outdated
Comment thread tests/validation/test_model_metadata.py
Comment thread src/ga4gh/core/metadata.py Outdated
Comment thread src/ga4gh/core/metadata.py Outdated
@korikuzma
korikuzma requested a review from larrybabb September 28, 2026 13:48

@larrybabb larrybabb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@korikuzma
korikuzma merged commit 0476ec6 into vrs/2.1.0 Sep 29, 2026
24 of 32 checks passed
@korikuzma
korikuzma deleted the ballot-updates branch September 29, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority:high High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants