feat: update models vrs 2.1.1-ballot.2026-09.1 - #658
Conversation
* core version: 1.3.0-ballot.2026-09.1
There was a problem hiding this comment.
Here's a claude review
Findings
-
(Medium) packaging is imported but not a declared dependency. metadata.py:6 adds from packaging.version import Version at module top level, but packaging isn't in pyproject.toml's runtime dependencies (pydantic, bioutils, requests, canonicaljson, typing-extensions). I confirmed in the venv that packaging is Required-by only dev/notebook tools (pytest, sphinx, jupyter) — none of the runtime deps pull it. A minimal pip install ga4gh.vrs[extras] could therefore fail at import ga4gh.core.metadata with ModuleNotFoundError. In practice packaging is near-ubiquitous, so it likely won't bite most users and CI never sees it — but for a reference library an undeclared top-level import is a real gap.
- Fix: add "packaging" to dependencies, or avoid the dep entirely by comparing pydantic.VERSION (a tuple-parseable string pydantic already exposes).
Co-authored-by: Larry Babb <lbabb@broadinstitute.org>
Co-authored-by: Larry Babb <lbabb@broadinstitute.org>
Changes
_abstractclassvarRelativeAlleleto Variation rootSchema changes
note: Use /json rather than *-source.yaml