Repository navigation
fix(ruby-llm): contain recalled tracing safety gaps - #1091
Merged
Merged
Conversation
Qualify native lifecycle error coverage and test interruption, HTTP timeout, cancellation and tool exceptions. Replace the legacy fixture's namespace trust with an exact attribute allowlist and regression tests. Hold the copied customer route pending a maintained legacy package rather than claim the fixture is an installable replacement. Co-Authored-By: Claude Code <noreply@anthropic.com>
Test the documented two-turn session in a fresh process without the legacy patch, while preserving unrelated shared-provider tracing. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1077 after reproducing both recall findings with released gems and synthetic loopback traffic.
Explicit remaining work
This is containment, not a complete legacy integration release. The namespace bypass is fixed in the repository fixture, but this PR does not deliver a maintained, installable Ruby privacy adapter. Existing copied installations do not automatically receive that fix. The customer legacy route remains disabled until migration to native tracing or delivery of that package. No new copied helper is recommended and no package availability is invented.
The upstream native interruption behavior is unchanged; this PR corrects its documented coverage and provides tested alternatives, rather than monkeypatching RubyLLM.
Verification
All local execution used the network-denying sandbox, synthetic credentials and disposable homes. No provider or Future AGI Cloud calls.
Re-run native checks from the repository root with
node --test scripts/ruby-llm-page.test.mjsandRUBY_LLM_VERSION=2.1.1 ruby scripts/ruby-llm-native.test.rbafter installing the versions listed in the native test header. Run the legacy checks withbundle exec rake testinexamples/frameworks/ruby-llm, setting RUBY_LLM_VERSION before installing its Gemfile. Use loopback-only networking for both suites.E2E coverage
Not applicable (no e2e/ harness). Runtime integration behavior is covered by real released RubyLLM gems and decoded OTLP; browser validation covers the rendered guide. No live backend UI mapping is claimed.
No registry publication, release, merge, or default-branch push is included.
🤖 Generated with Claude Code