ci: add zarr to test_downstream extra (test_xarray_zarr skipped since #1553) - #2109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1553 moved the downstream job's dependencies from
ci/environment-downstream.yml(which listedzarr) into the newtest_downstreamextra, but zarr didn't make the new list, sotest_downstream.py::test_xarray_zarrhas import-skipped on every run since April 2024 while the job stays green — e.g. the latest master run:test_xarray_zarr SKIPPED. The README still describes this job as running "very minimal tests against pandas and zarr" (README L77–L82).Verified on my fork: unchanged master reproduces the skip (1, 2); with this one-line change the test runs and passes on current zarr 3.1.6 (3).
Disclosure: found while auditing CI logs with an AI assistant (Claude); I re-verified the commit history and reran the reproduction myself before opening this.