Repository navigation
fix(schemas): allow modelName, setAuthParams, getAuthorizationRequirements in api-module definition - #701
fix(schemas): allow modelName, setAuthParams, getAuthorizationRequirements in api-module definition#701seanspeaks wants to merge 7 commits into
Conversation
✅ Deploy Preview for friggframework-org canceled.
|
Add frigg validate --module (also frigg validate module) to load Definition from ./index.js, run validateApiModuleDefinition and checkModuleDefinition, and exit non-zero with JSON field paths. Supports --json and -v. Stacked on #701 (api-module schema fields) and includes #666 (ADR-051 frigg validate app mode) so the CLI canary has both. Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
Add frigg validate --module (also frigg validate module) to load Definition from ./index.js, run validateApiModuleDefinition and checkModuleDefinition, and exit non-zero with JSON field paths. Supports --json and -v. Stacked on #701 (api-module schema fields) and includes #666 (ADR-051 frigg validate app mode) so the CLI canary has both. Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
Frigg 2.0.1 review (Group 2) — COMMENT onlyChecklist (with
Verdict (would): would approve FindingsNone blocking. |
Follow-up (COMMENT)should-fix (merge with Scenario: Merge order without reconciling |
d5e6de1 to
3b01ea3
Compare
Add frigg validate --module (also frigg validate module) to load Definition from ./index.js, run validateApiModuleDefinition and checkModuleDefinition, and exit non-zero with JSON field paths. Supports --json and -v. Stacked on #701 (api-module schema fields) and includes #666 (ADR-051 frigg validate app mode) so the CLI canary has both. Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
…ments in api-module definition Add top-level modelName and API-key auth methods to the api-module-definition schema (additionalProperties remains false). validateApiModuleDefinition now accepts real Definitions via a schema view. Docs and Fathom fixture tests included. Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
devtools depends on @friggframework/test at the canary version. A packages/test change ensures lerna/auto includes it when cutting the #702 canary (same pattern as the core package.json bump). Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
Add frigg validate --module (also frigg validate module) to load Definition from ./index.js, run validateApiModuleDefinition and checkModuleDefinition, and exit non-zero with JSON field paths. Supports --json and -v. Stacked on #701 (api-module schema fields) and includes #666 (ADR-051 frigg validate app mode) so the CLI canary has both. Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
3b01ea3 to
32f702a
Compare
|
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
Rebase note for reviewers (rebased onto
🤖 Generated with Claude Code |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 32f702a. Configure here.
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "@friggframework/core", | |||
| "description": "Core framework for Frigg integrations (handlers, modules, encryption, database).", | |||
There was a problem hiding this comment.
Duplicate package description is ignored
Low Severity
The new description is overwritten by a later empty description in the same package.json. JSON parsers keep the last key, so npm publishes @friggframework/core with an empty description.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 32f702a. Configure here.




Summary
Allows
modelName,setAuthParams, andgetAuthorizationRequirementsin the api-module definition schema.Also includes
Port of PR #639’s EventBridge scheduler lazy-load (
@aws-sdk/client-schedulerloaded in the adapter constructor, declared as a core dependency) so CLI/canary consumers of@friggframework/coredo not crash on require. #639 itself was left untouched (#639 is stale vsnext); only the scheduler fix was ported here for the #701 → #702 stack.📦 Published PR as canary version:
2.0.0--canary.701.32f702a.0✨ Test out this PR locally via:
npm install @friggframework/admin-scripts@2.0.0--canary.701.32f702a.0 npm install @friggframework/core@2.0.0--canary.701.32f702a.0 npm install @friggframework/devtools@2.0.0--canary.701.32f702a.0 npm install @friggframework/eslint-config@2.0.0--canary.701.32f702a.0 npm install @friggframework/prettier-config@2.0.0--canary.701.32f702a.0 npm install @friggframework/schemas@2.0.0--canary.701.32f702a.0 npm install @friggframework/serverless-plugin@2.0.0--canary.701.32f702a.0 npm install @friggframework/test@2.0.0--canary.701.32f702a.0 npm install @friggframework/ui@2.0.0--canary.701.32f702a.0 # or yarn add @friggframework/admin-scripts@2.0.0--canary.701.32f702a.0 yarn add @friggframework/core@2.0.0--canary.701.32f702a.0 yarn add @friggframework/devtools@2.0.0--canary.701.32f702a.0 yarn add @friggframework/eslint-config@2.0.0--canary.701.32f702a.0 yarn add @friggframework/prettier-config@2.0.0--canary.701.32f702a.0 yarn add @friggframework/schemas@2.0.0--canary.701.32f702a.0 yarn add @friggframework/serverless-plugin@2.0.0--canary.701.32f702a.0 yarn add @friggframework/test@2.0.0--canary.701.32f702a.0 yarn add @friggframework/ui@2.0.0--canary.701.32f702a.0Note
Low Risk
Changes are schema/CLI validation and documentation; they do not alter runtime auth or deployment behavior unless consumers relied on previously invalid module shapes.
Reviewed by Cursor Bugbot for commit 32f702a. Bugbot is set up for automated code reviews on this repo. Configure here.