Repository navigation
ci: Cursor warm-boot env + fast Nx PR checks for next - #241
Open
seanspeaks wants to merge 2 commits into
Open
seanspeaks wants to merge 2 commits into
seanspeaks wants to merge 2 commits into
Conversation
Add a verified .cursor/environment.json (npm ci + OpenSSL 1.1 for mongodb-memory-server) so Frigg Module Builder Cloud Agents boot warm. Add pr-ci.yml that runs nx affected build/test only for packages/** changes on PRs to next/main, without touching release.yml (#238). Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
- Fetch full origin/<base> history (no --depth=1) and fail loudly on git diff merge-base errors instead of silent-green skip - Run bash .cursor/install.sh in PR CI for Cloud Agent parity on ubuntu-24.04 (mongodb-memory-server needs libcrypto.so.1.1) - Download libssl1.1 over https and verify pinned SHA-256 before dpkg Co-authored-by: Sean Matthews <sean.matthews@lefthook.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Frigg Module Builder Cloud Agents currently boot cold on this repo, and PRs into
nexthave no automated build/typecheck/unit-test gate (onlycodeql,codesee, andrelease). Broken module changes can merge without offline verification.This adds:
.cursor/environment.json+.cursor/install.sh— warm-boot install (npm ci, plus verified OpenSSL 1.1 formongodb-memory-serveron Ubuntu 24+) so Cloud Agents start ready to build/test modules..github/workflows/pr-ci.yml— fast PR checks onpull_request→next/mainusing Nx affectedbuild,test, scoped topackages/**so lockfile-wide fan-out does not re-run every credentialed suite. Uses the same.cursor/install.shas Cloud Agents.release.ymlis intentionally untouched (open PR #238 modifies it).Adversarial-review fixes (follow-up commit)
git fetch --no-tags origin <base>(full history intoorigin/<base>);git diffhas no|| trueso merge-base failures fail the job.bash .cursor/install.shonubuntu-24.04.libssl1.1.debfetched overhttps://and checked with pinned SHA-256 beforedpkg -i.Design notes (from inspecting
next)test/lint:fix. Only a few packages havebuild(tsc) orlint.lintis omitted from CI: almost everything only has mutatinglint:fix, and the fewlintscripts fail without unpublished eslint configs.release.yml/engines(>=18);.node-versionis still stale at16.15.0.packages/**files so Module Builder PRs that also touchpackage-lock.jsononly test the changed module(s).Verification
On this VM (Node 18.20.8):
bash .cursor/install.sh— exit 0 (idempotent)sha256sum -cOK; tampered.debrejectednpx nx affected -t build,test --files=packages/v1-ready/crossbeam/api.js— exit 0 (MMS-backed via@friggframework/testglobalSetup; 14 tests)npx nx affected -t build,test --files=packages/v1-ready/freshbooks/api.js— exit 0npx nx affected -t build,test --files=packages/v1-ready/clio/package.json— exit 0git diffexits 128 (fails loudly)Does not conflict with #238 (only adds/updates new workflow +
.cursor/files).