Repository navigation
feat: Supervise the Flow server when Frappe ships it - #653
Closed
ShrihariMahabal wants to merge 1 commit into
Closed
ShrihariMahabal wants to merge 1 commit into
ShrihariMahabal wants to merge 1 commit into
Conversation
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
[Medium impact] The changes appear safe to merge. Reviews (1) · Last reviewed commit: "feat(builder): Supervise the Flow server..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow now ships inside Frappe, so frappe/press#7703, which checks for the separate
frappe/flowapp, no longer turns on the supervised Flow server.[tool.pilot.processes.flow_server], the builder setsflow_server_manager: supervisorin the image'scommon_site_config.json, so feat(bench): Run the Flow server under supervisor #619 adds the supervisor program (a bench group can still setlocal).Needs #619 on app servers first.