feat: regenerate API client from OpenAPI spec - #17
Merged
Conversation
![convoy-sdk-reviewer[bot]](https://avatars.githubusercontent.com/u/66191081?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated regeneration via OpenAPI Generator (java/native) from
docs/v3/openapi3.yamlon frain-dev/convoy main. Hand-written webhook verify (src/main/java/com/getconvoy/webhook/) is untouched by the sync script.Note
Medium Risk
Public generated method signatures change (new positional
queryargument), which can break existing callers even though the new filter itself is optional and additive on the wire.Overview
Adds an optional
queryquery parameter togetEventDeliveriesPagedandbatchRetryEventDeliveryso clients can search by delivery id, event id, event type prefix, and endpoint name.This is a breaking public-API change: the generated method signatures insert
querybeforesort, so existing positional callers must be updated. The value is forwarded as thequeryquery string on/v1/projects/{projectID}/eventdeliveriesand/eventdeliveries/batchretry.Reviewed by Cursor Bugbot for commit 25898bb. Bugbot is set up for automated code reviews on this repo. Configure here.