Repository navigation
e2e: Drop the update tag from the aktualizr-lite rollout calls - #306
Merged
Merged
Conversation
742bed8 removed the tag from rollout creation, and 208e846 updated the fioup flow to match. The aktualizr-lite flow still passed the tag to `updates create-rollout` and `updates tail`, which now reject it. Signed-off-by: Andre Detsch <andre.detsch@foundries.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
@detsch - not sure how things were passing without this, but it looks like we need this fix. Any reason its still in draft? |
detsch
marked this pull request as ready for review
October 21, 2026 14:47
Member
Author
It is now ready for review, no reason for being a draft PR. This test is not part of CI yet, we should probably add it. |
doanac
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
742bed8 removed the tag from rollout creation, and 208e846 updated the fioup flow to match. The aktualizr-lite flow (
test_e2e_aklite_update_flow.py) still passes the tag tofiocli updates create-rolloutandfiocli updates tail, so it fails withaccepts 2 arg(s), received 3. CI doesn't catch it because it runsmake run, which leaves outmake aklite-run.Tested locally with
make aklite-run: bothtest_aklite_update_flow_libostreeandtest_aklite_update_flow_fiopullpass.Note for anyone running it locally: the test also needs DNS working inside Docker containers, because
docker compose upcontactshub.foundries.io. On my network that lookup timed out until the container used public DNS, which made the tests fail with exit code 110 after the rollout step.🤖 Generated with Claude Code