Repository navigation
ui/device-details - #254
Merged
Merged
Conversation
MiloCasagrande
changed the title
Member
Author
|
Other PRs in this stack, in order:
|
Member
|
I mostly like this. The one thing that feels odd is not controlling the size of the view for updates. As you can see here, it winds up dominating my screen so that I don't see the other things for the device: |
Member
Author
Yeah, that content grows too much indeed. I think we need a compromise there: show 5 or 6, and have a button/link to a new page with the complete list of updates. That will add a new tab at the top, "Updates". I noticed only now that there is a |
MiloCasagrande
force-pushed
the
ui/device-details
branch
from
September 1, 2026 15:24
c0e5b40 to
3c8fd35
Compare
Merged
MiloCasagrande
force-pushed
the
ui/device-details
branch
from
September 8, 2026 08:10
3c8fd35 to
79473cb
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MiloCasagrande
force-pushed
the
ui/device-details
branch
from
September 8, 2026 08:12
79473cb to
48f0c9c
Compare
MiloCasagrande
force-pushed
the
ui/device-details
branch
from
September 10, 2026 08:00
af4acda to
6c33d05
Compare
MiloCasagrande
force-pushed
the
ui/device-details
branch
from
September 18, 2026 08:42
a4d7ebb to
bb20644
Compare
MiloCasagrande
force-pushed
the
ui/device-details
branch
from
September 23, 2026 14:51
8025b72 to
d78fbcd
Compare
MiloCasagrande
force-pushed
the
ui/device-details
branch
2 times, most recently
from
October 9, 2026 13:00
de0c578 to
202c8d6
Compare
MiloCasagrande
force-pushed
the
ui/device-details
branch
from
October 20, 2026 07:49
202c8d6 to
6d0c875
Compare
MiloCasagrande
marked this pull request as ready for review
October 21, 2026 11:36
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Old /configs/device/:uuid GET routes now 301-redirect to /devices/:uuid/configs (and related). PATCH/DELETE and history also moved. No handler logic changed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Update template hrefs to use new URL structure: - /configs/device/:uuid -> /devices/:uuid/configs - /configs/device/:uuid/applied -> /devices/:uuid/applied-configs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Give roughly a third of seeded devices 10-15 fake update-history entries so the device's Update History page isn't always sparse, while leaving the rest empty so it stays realistic. About one in five entries is seeded as a failed install for visual variety. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
devicesUpdateGet used to hand the template raw DeviceUpdateEvent
data and let it slice DeviceTime with {{slice $step.DeviceTime 11 19}}
to get a clock-only timestamp. That slice has no bounds checking, so
a malformed or unexpectedly short DeviceTime from the gateway would
panic the template render instead of degrading gracefully.
buildUpdateSteps now formats each step's Time in Go (time.Format,
which can't panic) and exposes it as a plain field, alongside the
existing per-step Elapsed/Failed. Also documents that the aggregate
`failed` return value is an all-or-nothing rollup: any single event
reporting Success == false marks the whole update as failed, even if
later steps succeeded — there is no partial-success state in this UI.
Added TestBuildUpdateStepsClampsNegativeElapsed to cover the existing
elapsed-time clamp when events arrive out of order.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Use device indexes for sample variation so seed data remains reproducible and avoids non-cryptographic randomness warnings. Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
MiloCasagrande
force-pushed
the
ui/device-details
branch
from
October 26, 2026 09:46
6d0c875 to
9245986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: redesign device detail page with new layout
Signed-off-by: Milo Casagrande mcasagra@qti.qualcomm.com