Repository navigation
Clean sample on the clean #48
Description
Legacy part of our sample doesn't have almost clean architecture.
That's why, we had some stuck trouble with relations between presentation layer and data layer.
For example check out these files CharacterPageDataSource.kt and CharactersListViewModel.kt and you'll see.
GlobalScope.launch(CoroutineExceptionHandler { _, _ ->
retry = {
loadInitial(params, callback)
}
networkState.postValue(NetworkState.Error())
})
DataSource shouldn't know anything about scopes.
Necessary to make sample architecture more cleaner with weak deps between presentation layer and data by implementing use case on domain layer.
It will be necessary for future, for example, to make tests functionality from Forma.
Activity
ntnsmirnov commentedon Dec 12, 2020
Here is the class diagramm
I painted the main problems in red. And we also need usecases.
P10: promote historical GH backlog into TICKETS board (#209)
P13: promote remaining open GH backlog into TICKETS (#251)
stepango commentedon Aug 6, 2026
Promoted to board ticket F-116 (P13) on
TICKETS.mdwithpriority: now/cron may continue. Landed board update: #251 — will close this issue when the sample domain clean-architecture slice lands onv2.F-116: sample domain use cases; kill GlobalScope in list paging (#252)
stepango commentedon Aug 6, 2026
Landed on
v2via F-116 / PR #252 — domain use cases on characters core; list paging uses viewModelScope (no GlobalScope); presentation no longer injects MarvelRepository.