Repository navigation
feat(wildbloomd): let the ICE issuer hand out STUN alone - #91
Merged
Merged
Conversation
--turn-issuer with only stun: URLs now needs no secret: it returns the URLs with an empty username and credential and mints nothing. The secret is required if and only if a --turn-url is turn: or turns:, and one given with STUN alone stops start-up. Flag, env and route names are unchanged.
TheCryptoDonkey
force-pushed
the
feat/wildbloomd-stun-only
branch
from
October 23, 2026 21:36
08df6bd to
d1c94de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #89 (protocol and vectors); independent of the Drop change (#90). Optional: nothing here is needed for the owner's node on stall, because Drop falls back to its built-in STUN server on a 404.
Flag, environment variable and route names are unchanged.
--turn-issuer --turn-url stun:stun.example.net:3478, with no secret, is now the STUN-only mode.grants/turn.rs:ice_urlsno longer requires a TURN URL. Newhas_turn_url.TurnIssuerholds anOption<TurnSecret>; for STUN alonemintreturns{credential:"", urls, username:""}and mints no label; for TURN it is the same HMAC as before, and a TURN issuer built without its secret answers 503 rather than signing nothing. The log line is now "issued a pair of ICE configurations" (still no URLs or usernames).main.rs: the secret is required if and only if a configured URL isturn:/turns:. A--turn-secret-fileorWILDBLOOM_TURN_SECRETgiven with STUN-only URLs stops start-up with "a TURN secret was given but no --turn-url is turn: or turns:". The start-up rule is a small function with its own test. The secret variable is still removed from child environments in every mode (the existing tests cover it). Help text updated.docs/THREAT-MODEL.mdupdated; the operator notes and self-hoster recipes are in the protocol PR (docs: let direct send run on STUN alone (protocol and vectors) #89).Tests:
cargo test -p wildbloomd(163 plus the integration targets pass),cargo clippy --workspace --all-targets -- -D warnings,cargo fmt --all -- --check. New tests: a STUN-only issuer returns exact canonical bytes with empty credentials and needs no secret; a TURN issuer with no secret is 503;ice_urlsaccepts STUN alone; start-up accepts STUN-only with no secret, refuses STUN-only with a secret file or the variable, refuses TURN with no secret. One unrelated test,replicas::tests::interrupted_temporary_write_keeps_the_committed_revision_and_unknown_state_refuses, failed once in a parallel run and passed on rerun; I did not investigate it.Not done: renaming the flags or route to ICE names (left as an open question in the spec), any redeploy.