Skip to content

fix: keep the signing identity and team out of macOS evidence files #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCryptoDonkey merged 1 commit into from
Oct 23, 2026
Merged

fix: keep the signing identity and team out of macOS evidence files #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/notarize-macos-preview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,11 @@ def main():
args.output.mkdir(mode=0o700)
evidence = {
"input": args.input.name, "input_sha256": args.sha256,
"source_commit": args.source_commit, "signing_identity": args.identity,
"team_id": args.team_id, "started_at": datetime.now(timezone.utc).isoformat(),
# The identity and team are checked below but never written down:
# evidence files get committed, and the certificate holder stays out
# of the repository.
"source_commit": args.source_commit, "signing_identity": "(withheld)",
"team_id": "(withheld)", "started_at": datetime.now(timezone.utc).isoformat(),
"script_sha256": digest(Path(__file__)), "passed": False,
"scope": "Local Developer ID signing and Apple notarisation; no updater signature, publication or clean-machine acceptance",
}
Expand Down
Loading