Repository navigation
Keep the recording bound to the acknowledged room epoch - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two visitors start an empty room, a losing browser can see the winning epoch while publication is still unready. The later ACK used to compare against that intervening notification and skip the recording handoff, leaving the old candidate bound to the player.
Compare the acknowledged epoch with the recording’s actual bound epoch. Retire the losing candidate on the existing empty player and original pending Play; same-epoch ACKs keep their source. Native and non-recorded playback retain the previous-state comparison.
Validation: the faithful publishing-then-ACK fixture fails on the previous controller and passes with this change, including adoption during publication, pause, abort, departure and stale callbacks. All 30 controller lifecycle groups, 340 unit tests, site build and diff checks pass. An initial server-test timeout passed unchanged in isolation and in the subsequent serial suite; its 10-second bound remains unchanged. This fixes that race; separate intermittent M1 cold-start and peer-contribution qualification remain open.