Repository navigation
Keep the mix label clear of native fullscreen controls - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iPhone, the “4K / ORIGINAL MIX” overlay covered Safari’s native fullscreen control when the viewer tapped the picture. Move the existing quality label into the source caption below the player and use normal document flow on mobile and desktop. The existing quality updates remain unchanged.
Also record the completed physical Safari baseline:330seconds of advancing ManagedMediaSource playback through an actual recording wrap, zero observed stalls/player errors, and owner feedback “Smooth, no pauses”. The sanitised receipt explicitly leaves phone cache state, native dimensions/frame/drop/audio properties and peer/TURN qualification unmeasured.
Validation: all6 mobile/desktop layouts across the homepage, Live media and Media lab keep the label outside/below the video with no horizontal overflow; site build,30controller fixture groups and diff checks passed. Layout checks are not a native iOS fullscreen interaction test.