Repository navigation
Conversation
- Move iOS sources to ios/apple_maps_flutter/Sources/apple_maps_flutter and add Package.swift (iOS 13, FlutterFramework dependency). - Remove the Objective-C registration shim; the plugin class is now the Swift class AppleMapsFlutterPlugin (pluginClass unchanged). - Add explicit Flutter/UIKit imports that the CocoaPods umbrella header used to provide. - Podspec: new source path, iOS 13.0, Swift 5.9, and metadata that passes pod lib lint without warnings. - Require Flutter 3.5+ (Dart 3); bump version to 1.5.0. - Replace deprecated package:flutter/material.dart: the plugin now only imports widgets.dart (no new dependency); the example uses material_ui. - Fix analyzer warnings and deprecations (Color.value, mock handlers). - Example: fix driver-test timing race and a wrong assertion; ignore Flutter/ephemeral; keep Flutter 3.50's project migrations.
m3n99
force-pushed
the
swift-package-manager
branch
from
November 12, 2026 17:16
ca01e28 to
00a8cd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Swift Package Manager support to the iOS implementation. CocoaPods keeps working. The Dart API, method channel names,
platform-view id and map logic are unchanged.
Changes
git mv, history kept) fromios/Classestoios/apple_maps_flutter/Sources/apple_maps_flutter, plus a newios/apple_maps_flutter/Package.swift(iOS 13.0, depends onFlutterFramework).AppleMapsFlutterPlugin.h/.mshim is removed andSwiftAppleMapsFlutterPluginisrenamed to
AppleMapsFlutterPlugin, sopluginClassand the generated registrant are unchanged.import Flutter/import UIKitin the files that relied on the CocoaPods umbrella header.source_filespath,public_header_filesremoved, iOS 13.0, Swift 5.9, and fixed metadata (summary, licensetype, source).
sdk: ">=3.0.0 <4.0.0",flutter: ">=3.41.0"(needed forFlutterFramework), version 1.5.0.flutter/widgets.dartinstead of the deprecatedmaterial.dart; its only Material use was5
Colors.black/transparentdefaults, now identicalconst Color(...)values, so there's no new dependency.Color.valueisnow
toARGB32(). The example usesmaterial_ui.==operators takeObject, unnecessary imports removed, test mocks useTestDefaultBinaryMessengerBinding.UIScene,
@main);Flutter/ephemeral/ignored; driver tests wait for native layout before reading map state; a wrong assertion intestMyLocationButton initial value trueis fixed.Testing
On Flutter 3.50.0, Xcode 27.2, iOS simulator:
flutter analyze: no issuesflutter test: 42 passedFlutterGeneratedPluginSwiftPackageenable-swift-package-manager: false): passesNotes
pod lib lintbuilds without warnings but can't pass on Xcode 27.2: Xcode only builds iOS 15.0+, and theFlutterpod lintpulls from CocoaPods trunk declares iOS 11.0.
FlutterFramework. Test CocoaPods on an unmigrated example. Apps that use the plugin are not affected.