Migrate from dart_skills_lint to skills_lint - #9974
Open
reidbaker-agent wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
cc @reidbaker for review |
reidbaker
reviewed
Aug 24, 2026
- Update tool/pubspec.yaml dependency from dart_skills_lint to skills_lint - Rename tool/dart_skills_lint.yaml to tool/skills_lint.yaml and update root key - Rename .agents/skills/dart_skills_lint_ignore.json to skills_lint_ignore.json - Update validate_skills_test.dart imports and config file path - Update validate_skills_hook.sh to use flutter pub run skills_lint
reidbaker
force-pushed
the
migrate-skills-lint
branch
from
August 24, 2026 15:34
141fba9 to
a574df7
Compare
reidbaker
approved these changes
Aug 24, 2026
reidbaker
marked this pull request as ready for review
August 24, 2026 15:36
reidbaker
requested review from
a team,
kenzieschmoll and
srawlins
as code owners
August 24, 2026 15:36
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the project's skill validation tool from dart_skills_lint to skills_lint. This involves updating the validation hook script, the configuration file, dependencies in pubspec.lock and tool/pubspec.yaml, and the corresponding test file. The review feedback suggests using the modern dart run command instead of the deprecated dart pub run in the validation hook script.
kenzieschmoll
approved these changes
Aug 24, 2026
pq
approved these changes
Aug 24, 2026
pq
left a comment
pq
left a comment
Contributor
There was a problem hiding this comment.
Modulo the preferring dart run comment, LGTM!
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
reidbaker
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/devtools/9974, because - The status or check suite ubuntu-latest test_ddc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skills_lint code is moving out of flutter/agent-plugins to its own github repo skills_lint.dart.
Related to #9974
Agent authored description
Follows the migration guide in
google/skills_lint.dartto migrate DevTools fromdart_skills_linttoskills_lint.Changes
tool/pubspec.yamldependency to useskills_lintfromhttps://github.com/google/skills_lint.dart.git.tool/dart_skills_lint.yamltotool/skills_lint.yamland update top-level YAML key toskills_lint:..agents/skills/dart_skills_lint_ignore.jsonto.agents/skills/skills_lint_ignore.json.tool/test/validate_skills_test.dartimports and config path..agents/scripts/validate_skills_hook.shto usedart pub run skills_lint.Pre-launch Checklist
///).