Repository navigation
build: fail when a reference decoder patch cannot be applied - #422
Open
rsanchez87 wants to merge 2 commits into
Open
rsanchez87 wants to merge 2 commits into
rsanchez87 wants to merge 2 commits into
Conversation
ylatuya
reviewed
Nov 6, 2026
Contributor
|
Are these patches failing on Windows? I would also fix the patches |
Contributor
Author
I also checked all patches in patches and jm, and they all apply correctly |
download_deps.py ignored the result of apply_patch(), so a failing patch only printed a warning and the script still ended with "All dependencies downloaded successfully!". Try all the MPEG-4 AAC patches and exit with an error listing the ones that failed. A patch that is already applied is detected with git apply --reverse --check and counts as success, so the script can still be run twice
rsanchez87
force-pushed
the
build/fatal-patch-failures
branch
from
November 6, 2026 10:03
16e60d2 to
c5402f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #421.
download_deps.pyignored the result ofapply_patch(): a failing patch only printed a warning and the script still ended with "All dependencies downloaded successfully!".Now all four MPEG-4 AAC patches are tried and the script exits with an error listing the ones that failed. Patches that are already applied are detected with
git apply --reverse --check, so the script can still be run twice.Tested the four real patches on a synthetic tree (fresh, re-run, failing patch), with and without
patch. Stacked on #421.