Repository navigation
Selector toolbar position - #591
Merged
Merged
Conversation
Amir-P
reviewed
Sep 14, 2026
Comment on lines
+1434
to
+1435
| ? presenter.top - _selectorScreenPadding - childSize.height | ||
| : presenter.bottom + _selectorScreenPadding; |
Member
There was a problem hiding this comment.
Thanks for working on this and it works good except I believe there is extra padding now as you can see from the screenshots. I believe you shouldn't account for _selectorScreenPadding here as they would be added in _fitInsideScreen if needed (to push it away from screen edges).
Before:
After:
amantoux
force-pushed
the
selector-toolbar-position
branch
from
October 11, 2026 17:34
836e461 to
165a2a1
Compare
amantoux
force-pushed
the
selector-toolbar-position
branch
from
October 11, 2026 17:42
165a2a1 to
c4c284e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
==========================================
+ Coverage 88.08% 88.10% +0.02%
==========================================
Files 63 63
Lines 10903 10984 +81
==========================================
+ Hits 9604 9678 +74
- Misses 1299 1306 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Color and heading selectors can cover the formatting toolbar when it sits above the keyboard. Position selectors below the presenter when there is room, and flip above it when that side offers more space. Use the full toolbar's vertical bounds while keeping horizontal alignment with the button, and preserve keyboard and safe-area constraints.