Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates FirebaseUIError to retain the original Firebase error as its cause and introduces warning logs for configuration-related errors. Corresponding unit tests and documentation updates have also been added. Feedback on these changes suggests optimizing the configuration error code lookup by using a Set instead of an array, handling already-wrapped FirebaseUIError instances in handleFirebaseError to prevent double-wrapping and duplicate warnings, and adding a test case to verify this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the original Firebase error on
FirebaseUIErrorand warns about configuration errors, so a translated message no longer hides the real cause.Changes
FirebaseUIErrorkeeps the originalFirebaseErrorascause, so apps can log or report the untranslated message.handleFirebaseErrorlogs Firebase configuration error codes, such asauth/api-key-expired, withconsole.warn.Maintainer note: Fixes internal CPRN-594