Repository navigation
Declare the node24 runtime - #5
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cakasim
approved these changes
Oct 15, 2026
`@actions/cache` resolves to ./github-actions-toolkit/packages/cache, which CI never checked out, so Tests, Check dist/ and Licensed have been red since the fork. A shared setup-toolkit step now checks out finmid/github-actions-toolkit at local-cache-3.2.4 (upstream cache 3.2.4 + the local cache client), which rebuilds dist/ byte for byte. - Tests: unit tests ignore the toolkit's own suites; e2e save/restore runs in one job, since the local backend keeps archives under /cache on the runner; proxy jobs dropped (the local backend makes no network calls) - Check dist/ and Licensed: inlined so they can build the toolkit first - .licenses regenerated with licensed 5.1.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Declares the
node24runtime instead ofnode20inaction.yml,restore/action.ymlandsave/action.yml.dist/is untouched.Motivation and Context
Every job using this action warns:
The runner already forces this exact bundle onto Node 24, and it works there. Declaring
node24makes the manifest say what actually runs and silences the warning. It does not change behaviour.This deliberately does not rebase onto upstream
actions/cachev5. That would mean re-syncing the customisedgithub-actions-toolkitlocal-cachebackend (seefinmid-README.md), which is a much bigger change.How Has This Been Tested?
Ran all four bundles (
dist/{restore,save,restore-only,save-only}/index.js) under Node v24.18.0. Each loads its full module graph and falls back gracefully with no cache backend (cache-hit=false), the same as on Node 20.Types of changes
Not rolled out. Consumers pin this action by SHA (
backend/build, frontend workflows), so nothing changes until a tag (suggest1.0.2) and a pin bump. finmid/actionsbackend/buildfollows separately.CI fix (second commit)
Tests, Check dist/ and Licensed had been red since the fork (the March PR too):
@actions/cacheresolves to./github-actions-toolkit/packages/cache, which CI never checked out..github/actions/setup-toolkitchecks outfinmid/github-actions-toolkitatlocal-cache-3.2.4(21ead9f: upstream@actions/cache3.2.4 + the local cache client commit). This reproducesdist/byte for byte. The toolkit'slocal-cachebranch can't be used: its Dec 2025 merge from main doesn't compile and would add a v2 code path that bypasses the local client./cacheon the runner. The proxy e2e jobs are dropped because the local backend makes no network calls..licensesregenerated with licensed 5.1.0.🤖 Generated with Claude Code