Repository navigation
fix: resolve glob handles in POSIX::isatty - #1934
Merged
Merged
Conversation
Resolve the filehandle carried by a GLOB through RuntimeScalar's shared RuntimeIO helper instead of casting its RuntimeGlob representation directly. Add a focused regression for STDIN and STDOUT on both execution backends. Fixes #1932 Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
fglock
force-pushed
the
fix/posix-isatty-glob
branch
from
October 30, 2026 10:53
1fb4348 to
0b74ff8
Compare
fglock
marked this pull request as ready for review
October 30, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POSIX::isattywith the sharedRuntimeScalar.getRuntimeIO()helper instead of castingRuntimeGlobtoRuntimeIO.*STDINand*STDOUTand record the compatibility fix in the changelog.Closes #1932.
Validation
prove src/test/resources/unit/posix_isatty_glob.tunder system Perl: pass.timeout 60 ./jperl src/test/resources/unit/posix_isatty_glob.t: pass (2 tests).timeout 60 ./jperl --interpreter src/test/resources/unit/posix_isatty_glob.t: pass (2 tests).nice -n 19 make: pass.make check-linksand offline Lychee on changed Markdown: pass.The original CPAN run
20261030-095654-34969failed on both backends. A freshtimeout 300 ./jcpan -t IO::Pty::Easyrerun passedt/open-close.t, skipped fork-dependent tests, then timed out before the full suite reported; no orphaned test process remained.